Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8s-cloud-builder and k8s-ci-builder to Go 1.19.8 #3006

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Apr 6, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Bump k8s-cloud-builder and k8s-ci-builder to Go 1.19.8

Go 1.20.3 bump has been already merged as part of #3004

Which issue(s) this PR fixes:

xref #2991

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Bump k8s-cloud-builder and k8s-ci-builder to Go 1.19.8

/assign @saschagrunert @cpanato @puerco @cici37
cc @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 6, 2023
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 6, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Apr 6, 2023
@xmudrii
Copy link
Member Author

xmudrii commented Apr 6, 2023

/hold
for cherry-picks to be merged

@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 6, 2023
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2023
@puerco
Copy link
Member

puerco commented Apr 6, 2023

Thanks!!
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cici37
Copy link
Contributor

cici37 commented Apr 6, 2023

/lgtm Thanks!

@xmudrii
Copy link
Member Author

xmudrii commented Apr 6, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit a1c1cac into kubernetes:master Apr 6, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Apr 6, 2023
@xmudrii xmudrii deleted the builders-go1198 branch April 6, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants