Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop 32bit arm from package builds #2960

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Mar 13, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

We stopped building 32bit arm releases in kubernetes/kubernetes#115742, means we cannot publish packages for that platform any more.

Which issue(s) this PR fixes:

Refers to: kubernetes/sig-release#2189

And:

Special notes for your reviewer:

We do not distinguish package builds for release branches and minor releases right now. Means this change will affect both of them.

Does this PR introduce a user-facing change?

Stopped building packages for 32 bit ARM platforms for Kubernetes >= v1.27.0.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Mar 13, 2023
@k8s-ci-robot k8s-ci-robot requested review from cici37 and jimangel March 13, 2023 09:08
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 13, 2023
packages/deb/build.go Outdated Show resolved Hide resolved
@saschagrunert saschagrunert added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2023
@afbjorklund
Copy link

I guess having to drop existing releases from (arm) packaging, is a side-effect of

@dims
Copy link
Member

dims commented Mar 13, 2023

/lgtm

thanks @saschagrunert

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2023
@sftim
Copy link
Contributor

sftim commented Mar 13, 2023

Changelog nit:

-Stopped building packages for 32bit arm platforms.
+Stopped building packages for 32 bit ARM platforms.

@saschagrunert
Copy link
Member Author

Changelog nit:

-Stopped building packages for 32bit arm platforms.
+Stopped building packages for 32 bit ARM platforms.

Thanks! Fixed as suggested.

@liggitt
Copy link
Member

liggitt commented Mar 13, 2023

We do not distinguish package builds for release branches and minor releases right now. Means this change will affect both of them.

that requirement seems new, right? otherwise, how did we introduce darwin/arm64 builds in 1.21 in kubernetes/kubernetes#97743 without breaking releases on still-supported <1.20 versions?

@liggitt
Copy link
Member

liggitt commented Mar 13, 2023

the architectures we release for seem like they should be able to be overridden per minor version

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 14, 2023
@saschagrunert
Copy link
Member Author

I modified the PR to drop the arm architecture only for Kubernetes >= v1.27.

@saschagrunert
Copy link
Member Author

@kubernetes/release-engineering PTAL
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2023
@xmudrii
Copy link
Member

xmudrii commented Mar 15, 2023

@saschagrunert Should we keep this on hold until patch releases are not out?
/hold
(unhold if answer is no)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 15, 2023
@saschagrunert
Copy link
Member Author

@xmudrii yep makes sense.

@cpanato
Copy link
Member

cpanato commented Mar 25, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2023
@cpanato
Copy link
Member

cpanato commented Mar 25, 2023

patches are out
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2023
@dims
Copy link
Member

dims commented Mar 27, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit 19e5697 into kubernetes:master Mar 27, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Mar 27, 2023
@saschagrunert saschagrunert deleted the arm-32 branch March 27, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants