Updated registry references to registry.k8s.io #2905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
sig/release
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
|
/retest |
sftim
reviewed
Feb 13, 2023
Comment on lines
14
to
18
| # ---> staging-registry.k8s.io/debian-iptables-amd64:TAG | ||
| # ---> staging-registry.k8s.io/debian-iptables-arm:TAG | ||
| # ---> staging-registry.k8s.io/debian-iptables-arm64:TAG | ||
| # ---> staging-registry.k8s.io/debian-iptables-ppc64le:TAG | ||
| # ---> staging-registry.k8s.io/debian-iptables-s390x:TAG |
There was a problem hiding this comment.
I'm not sure these are right
There was a problem hiding this comment.
I think you're right, but I also don't think it's correct as it currently is. When I run the make file it seems to want to push to gcr.io/k8s-staging-build-image/debian-iptables-${ARCH}:${TAG} I'll update the file with the correct reference.
sftim
reviewed
Feb 13, 2023
Comment on lines
14
to
18
| # ---> staging-registry.k8s.io/distroless-iptables-amd64:TAG | ||
| # ---> staging-registry.k8s.io/distroless-iptables-arm:TAG | ||
| # ---> staging-registry.k8s.io/distroless-iptables-arm64:TAG | ||
| # ---> staging-registry.k8s.io/distroless-iptables-ppc64le:TAG | ||
| # ---> staging-registry.k8s.io/distroless-iptables-s390x:TAG |
There was a problem hiding this comment.
I'm not sure these are right
sftim
reviewed
Feb 13, 2023
images/build/setcap/README.md
Outdated
Comment on lines
18
to
22
| # ---> staging-registry.k8s.io/setcap-amd64:TAG | ||
| # ---> staging-registry.k8s.io/setcap-arm:TAG | ||
| # ---> staging-registry.k8s.io/setcap-arm64:TAG | ||
| # ---> staging-registry.k8s.io/setcap-ppc64le:TAG | ||
| # ---> staging-registry.k8s.io/setcap-s390x:TAG |
There was a problem hiding this comment.
I'm not sure these are right
k8s-ci-robot
added
the
needs-rebase
|
/retest |
1 similar comment
|
/retest |
|
/sig k8s-infra |
k8s-ci-robot
added
the
sig/k8s-infra
Signed-off-by: rsadowsk <[email protected]>
k8s-ci-robot
added
size/L
k8s-ci-robot
added
the
lgtm
saschagrunert
approved these changes
Feb 16, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rjsadow, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
ref: #2904
For kubernetes/k8s.io#4738
Which issue(s) this PR fixes:
None, partial completion of #2904
Does this PR introduce a user-facing change?