Retry docker manifest push on network failure
#2817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/release-eng
saschagrunert
force-pushed
the
retry-manifest-push
branch
2 times, most recently
from
386588f to
74637f1
Compare
k8s-ci-robot
added
size/S
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We can encounter network issues on pushing the manifest as described in: kubernetes#2810 We now retry in case of that network error up to 5 times by using an exponential back off timer. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
retry-manifest-push
branch
from
74637f1 to
43e131f
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind flake
What this PR does / why we need it:
We can encounter network issues on pushing the manifest as described in: #2810
We now retry in case of that network error up to 5 times by using an exponential back off timer.
Which issue(s) this PR fixes:
Fixes #2810
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?