Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Go 1.19.4 and 1.18.9 based images #2794

Merged
merged 3 commits into from
Dec 7, 2022
Merged

Build Go 1.19.4 and 1.18.9 based images #2794

merged 3 commits into from
Dec 7, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Dec 5, 2022 •
edited
Loading

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

  • Build Go 1.19.4 and 1.18.9 based images
  • Update references to kube-cross in dependencies.yaml from v1.25.0 to v1.26.0
  • Add an entry for kube-cross v1.25.0 (previous release branch) to dependencies.yaml

Which issue(s) this PR fixes:

Part of #2788

Does this PR introduce a user-facing change?

Build Go 1.19.4 and 1.18.9 based images

cc @kubernetes/release-engineering @leonardpahlke

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Dec 5, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 5, 2022
This was referenced Dec 5, 2022
Closed
Merged
@jeremyrickard jeremyrickard mentioned this pull request Dec 6, 2022
Merged
@xmudrii xmudrii mentioned this pull request Dec 6, 2022
Merged
@xmudrii xmudrii marked this pull request as ready for review December 6, 2022 23:51
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Dec 7, 2022

Looks like a combination of timeout and rate limit.
/retest

@ameukam
Copy link
Member

ameukam commented Dec 7, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2022
@palnabarun
Copy link
Member

/test pull-release-integration-test

@cpanato
Copy link
Member

cpanato commented Dec 7, 2022

/test pull-release-integration-test

cpanato
cpanato approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cpanato
Copy link
Member

cpanato commented Dec 7, 2022

there is something wrong with the integration tests as we can see in a fresh test pr #2801

i will look into it

@xmudrii
Copy link
Member Author

xmudrii commented Dec 7, 2022

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e2b1423 into kubernetes:master Dec 7, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Dec 7, 2022
@xmudrii xmudrii deleted the go-1194-1189 branch December 7, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@BenjaminKazemi BenjaminKazemi Awaiting requested review from BenjaminKazemi

@cici37 cici37 Awaiting requested review from cici37

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@jrsapi jrsapi Awaiting requested review from jrsapi

Assignees

@saschagrunert saschagrunert

@ameukam ameukam

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.
6 participants
@xmudrii @k8s-ci-robot @ameukam @palnabarun @cpanato @saschagrunert