Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new registry endpoint in the annoucements to the kubernetes-dev mailing list #2746

Merged
merged 4 commits into from
Nov 15, 2022
Merged

Use the new registry endpoint in the annoucements to the kubernetes-dev mailing list #2746

merged 4 commits into from
Nov 15, 2022

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Nov 7, 2022 •
edited
Loading

What type of PR is this?

/kind enhancement
/kind cleanup

What this PR does / why we need it:

registry.k8s.io has been active for some time now but we still use the old endpoint in our announcement emails.

kubernetes/kubernetes@97efa30

Which issue(s) this PR fixes:

Part of #2745

Special notes for your reviewer:

Does this PR introduce a user-facing change?

our mailing list announcements now uses the new registry.

/cc @saschagrunert @puerco @BenTheElder

@k8s-ci-robot
Copy link
Contributor

@upodroid: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind enhancement
/kind cleanup

What this PR does / why we need it:

registry.k8s.io has been active for some time now but we still use the old endpoint in our announcement emails.

kubernetes/kubernetes@97efa30

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

our mailing list announcements now uses the new registry.

/cc @saschagrunert @puerco @BenTheElder

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 7, 2022
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 7, 2022
upodroid
upodroid commented Nov 7, 2022
View reviewed changes
pkg/notes/document/document.go
@@ -30,7 +30,6 @@ import (
"github.com/sirupsen/logrus"
"golang.org/x/text/cases"
"golang.org/x/text/language"
"sigs.k8s.io/promo-tools/v3/image"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to update the constant in that library. I'll do that if the PR looks good and revert the change to this file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm.

https://kubernetes.slack.com/archives/CCK68P2Q2/p1667850096184829

TL;DR we need to have multiple complex conversations before merging kubernetes-sigs/promo-tools#669

@upodroid upodroid mentioned this pull request Nov 7, 2022
Merged
@ameukam
Copy link
Member

ameukam commented Nov 7, 2022

/lgtm
/assign @saschagrunert @puerco @cpanato

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2022
@ameukam
Copy link
Member

ameukam commented Nov 7, 2022

IMHO, we should merge this after the patch releases are done for November 2022. we still don't have the backports for k8s.gcr.io => registry.k8s.io merged in the release branches.

saschagrunert
saschagrunert reviewed Nov 8, 2022
View reviewed changes
pkg/notes/document/document.go Outdated
@@ -129,7 +128,7 @@ func fetchImageMetadata(dir, tag string) (*ImageMetadata, error) {
const linkBase = "https://console.cloud.google.com/gcr/images/k8s-artifacts-prod/us/"

for manifest, tempArchitectures := range manifests {
imageName := strings.TrimPrefix(manifest, image.ProdRegistry+"/")
imageName := strings.TrimPrefix(manifest, "registry.k8s.io/")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make "registry.k8s.io/" a const somewhere here?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2022
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 8, 2022
@upodroid
Copy link
Member Author

upodroid commented Nov 8, 2022

This is ready now.

@upodroid
Copy link
Member Author

upodroid commented Nov 8, 2022

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. do-not-merge/contains-merge-commits labels Nov 8, 2022
@upodroid
Copy link
Member Author

upodroid commented Nov 8, 2022

Adding label do-not-merge/contains-merge-commits because PR contains merge commits, which are not allowed in this repository.

First time I'm seeing this. Merge method is squash anyway so can we skip this?

@upodroid
Copy link
Member Author

This can be merged now. I rebased the PR.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f842735 into kubernetes:master Nov 15, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 15, 2022
@upodroid upodroid mentioned this pull request Dec 21, 2022
Closed
wespanther pushed a commit to wespanther/release that referenced this pull request Jun 2, 2023
@upodroid @wespanther
Use the new registry endpoint in the annoucements to the kubernetes-d…
1424753 
…ev mailing list (kubernetes#2746)

* use the new registry endpoint in the annoucements

* strip newline

* fix release manager urls + use a const for registry

* update all occurences of release-managers.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@puerco puerco Awaiting requested review from puerco

Assignees

@saschagrunert saschagrunert

@ameukam ameukam

@puerco puerco

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.
6 participants
@upodroid @k8s-ci-robot @ameukam @saschagrunert @puerco @cpanato