Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Go 1.19.3 and 1.18.8 based images #2732

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Build Go 1.19.3 and 1.18.8 based images #2732

merged 1 commit into from
Nov 2, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Oct 31, 2022 •
edited
Loading

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

Build Go 1.19.3 and 1.18.8 based images

Which issue(s) this PR fixes:

Part of #2726

Does this PR introduce a user-facing change?

Build Go 1.19.3 and 1.18.8 based images

cc @kubernetes/release-engineering

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 31, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 31, 2022
@xmudrii xmudrii added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Oct 31, 2022
@xmudrii xmudrii mentioned this pull request Oct 31, 2022
Closed
20 tasks
@cpanato
Copy link
Member

cpanato commented Nov 1, 2022

/test all

@cpanato
Copy link
Member

cpanato commented Nov 1, 2022

not yet published: golang:1.19.3-bullseye not found: manifest unknown: manifest unknown

@xmudrii xmudrii marked this pull request as ready for review November 1, 2022 20:54
@xmudrii
Copy link
Member Author

xmudrii commented Nov 1, 2022

/retest

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 1, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Nov 1, 2022

/retest

saschagrunert
saschagrunert approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2022
cpanato
cpanato approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3af3a4d into kubernetes:master Nov 2, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Nov 2, 2022
@xmudrii xmudrii deleted the go-1193-1188 branch November 2, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@jimangel jimangel Awaiting requested review from jimangel

@mkorbi mkorbi Awaiting requested review from mkorbi

Assignees

@saschagrunert saschagrunert

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.
4 participants
@xmudrii @k8s-ci-robot @cpanato @saschagrunert