Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix krel stage for using custom k8s refs #2522

Merged
merged 1 commit into from
May 11, 2022
Merged

Fix krel stage for using custom k8s refs #2522

merged 1 commit into from
May 11, 2022

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented May 11, 2022 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fixing krel stage for custom Kubernetes refs.

Which issue(s) this PR fixes:

Found in kubernetes/kubernetes#109938

Special notes for your reviewer:

Test run:

> export K8S_ORG=dims \
    K8S_REF=move-from-k8s.gcr.io-to-registry.k8s.io \
    TOOL_ORG=saschagrunert \
    TOOL_REF=custom-k8s-ref-fix && \
    go run ./cmd/krel stage

https://console.cloud.google.com/cloud-build/builds/5d83ca29-80c5-4ff4-8cfa-a394c74f28bb?project=kubernetes-release-test

Does this PR introduce a user-facing change?

Fixed `krel stage` for using custom Kubernetes refs via `K8S_ORG`, `K8S_REF` or `K8S_REPO`.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject labels May 11, 2022
@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label May 11, 2022
@saschagrunert saschagrunert mentioned this pull request May 11, 2022
Merged
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2022
@saschagrunert saschagrunert changed the title WIP: Fix krel stage for using custom k8s refs Fix krel stage for using custom k8s refs May 11, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 11, 2022
@saschagrunert
Copy link
Member Author

Test run works, it only aborts because the fork has no the 1.24.0 branch/tag available, which is a known limitation.

PTAL @kubernetes/release-engineering

cpanato
cpanato approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6dc4f13 into kubernetes:master May 11, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 11, 2022
@saschagrunert saschagrunert deleted the custom-k8s-ref-fix branch May 11, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@onlydole onlydole Awaiting requested review from onlydole

@thejoycekung thejoycekung Awaiting requested review from thejoycekung

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
3 participants
@saschagrunert @k8s-ci-robot @cpanato