-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert native go error wrapping #2483
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0eb9589. This reverts the native error wrapping as some functions are returning errors when they should not. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
k8s-ci-robot
added
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
kind/regression
Categorizes issue or PR as related to a regression from a prior release.
labels
Mar 31, 2022
k8s-ci-robot
added
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
needs-priority
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
labels
Mar 31, 2022
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: puerco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/release-eng
Issues or PRs related to the Release Engineering subproject
sig/release
Categorizes an issue or PR as relevant to SIG Release.
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
labels
Mar 31, 2022
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Mar 31, 2022
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
k8s-ci-robot
removed
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Mar 31, 2022
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Mar 31, 2022
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
area/release-eng
Issues or PRs related to the Release Engineering subproject
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/regression
Categorizes issue or PR as related to a regression from a prior release.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
needs-priority
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
sig/release
Categorizes an issue or PR as relevant to SIG Release.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind regression
What this PR does / why we need it:
This PR is a revert of 0eb9589 as functions were returning invalid errors.
We should move forward with the native wrapping but some patterns we were using with the errors package need additional validation to avoid returning empty errors.
Which issue(s) this PR fixes:
Some functions used to return errors relying on Wrap, like this:
... and they had this replacement which was returning errors without checking them:
Special notes for your reviewer:
This PR is also updating the bom libraries to their latest version
/assign @jimangel
/cc @saschagrunert @kubernetes/release-engineering
Does this PR introduce a user-facing change?