Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate container image signing in krel stage #2397

Merged
merged 1 commit into from
Mar 13, 2022
Merged

Integrate container image signing in krel stage #2397

merged 1 commit into from
Mar 13, 2022

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Pushed images and manifest lists on stage are now signed by using the release-sdk.

Which issue(s) this PR fixes:

Refers to #2383

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Added container image signing for intermediate container images produced by `krel stage`

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject labels Jan 19, 2022
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 19, 2022
saschagrunert
saschagrunert commented Jan 19, 2022
View reviewed changes
pkg/release/images.go Outdated Show resolved Hide resolved
saschagrunert
saschagrunert commented Jan 19, 2022
View reviewed changes
pkg/release/images.go Outdated Show resolved Hide resolved
@saschagrunert saschagrunert force-pushed the sign-stage branch 2 times, most recently from 584baa7 to c9d1fc2 Compare January 20, 2022 09:09
@saschagrunert saschagrunert mentioned this pull request Jan 20, 2022
Closed
@saschagrunert saschagrunert force-pushed the sign-stage branch 2 times, most recently from 10b9981 to b2965ae Compare January 20, 2022 10:45
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2022
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 26, 2022
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 31, 2022
@saschagrunert saschagrunert force-pushed the sign-stage branch 2 times, most recently from 9a2dfa6 to 8adad79 Compare January 31, 2022 13:31
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 2, 2022
@saschagrunert saschagrunert mentioned this pull request Feb 9, 2022
Closed
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2022
@saschagrunert
Copy link
Member Author

Switched to sigs.k8s.io/release-sdk v0.7.0 since this PR got a lgtm.

cpanato
cpanato approved these changes Mar 4, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2022
@saschagrunert saschagrunert mentioned this pull request Mar 7, 2022
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2022
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 7, 2022
@saschagrunert saschagrunert added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority labels Mar 7, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 7, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2022
@puerco
Copy link
Member

puerco commented Mar 8, 2022

/test pull-release-verify

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 10, 2022
@saschagrunert @puerco
Integrate container image signing in krel stage
0825de4 
Pushed images and manifest lists on stage are now signed by using the
release-sdk.

Signed-off-by: Sascha Grunert <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2022
@puerco
Copy link
Member

puerco commented Mar 13, 2022

Thank you @saschagrunert !!!
I've rebased your branch and ran a test run of staging now that we have the permissions in place. I am happy to report that the staged images are signed! 🎉🎉🎉🎉

/lgtm
/approve

image

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, puerco, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,puerco,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@puerco
Copy link
Member

puerco commented Mar 13, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit d8437e3 into kubernetes:master Mar 13, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 13, 2022
@saschagrunert
Copy link
Member Author

Thanks for merging @puerco! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puerco puerco puerco requested changes

@cpanato cpanato cpanato approved these changes

@sethmccombs sethmccombs Awaiting requested review from sethmccombs

@thejoycekung thejoycekung Awaiting requested review from thejoycekung

Assignees

@puerco puerco

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
4 participants
@saschagrunert @puerco @k8s-ci-robot @cpanato