Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s-cloud-builder/k8s-ci-builder: build using Go 1.17.6 #2393

Merged
merged 1 commit into from
Jan 19, 2022
Merged

k8s-cloud-builder/k8s-ci-builder: build using Go 1.17.6 #2393

merged 1 commit into from
Jan 19, 2022

Conversation

palnabarun
Copy link
Member

@palnabarun palnabarun commented Jan 18, 2022 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

k8s-cloud-builder/k8s-ci-builder: build using Go 1.17.6

PRs in k/k updating Go versions: kubernetes/kubernetes#107612 (master), kubernetes/kubernetes#107613 (release-1.23)

Which issue(s) this PR fixes:

Part of #2379

/assign @puerco @cpanato @Verolop @xmudrii @justaugustus @saschagrunert
cc @kubernetes/release-engineering

Special notes for your reviewer:

Does this PR introduce a user-facing change?

k8s-cloud-builder/k8s-ci-builder: build using Go 1.17.6

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 18, 2022
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 18, 2022
@palnabarun palnabarun mentioned this pull request Jan 18, 2022
Closed
27 tasks
@palnabarun palnabarun marked this pull request as ready for review January 18, 2022 16:38
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2022
@palnabarun
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2022
@palnabarun
Copy link
Member Author

/test pull-release-image-k8s-cloud-builder

@ameukam
Copy link
Member

ameukam commented Jan 19, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2022
cpanato
cpanato approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, palnabarun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@palnabarun
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 19, 2022
@cpanato
Copy link
Member

cpanato commented Jan 19, 2022

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority labels Jan 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit ac27e44 into kubernetes:master Jan 19, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Jan 19, 2022
@palnabarun palnabarun deleted the releng/update-k8s-ci/cloud-builder branch January 19, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@onlydole onlydole Awaiting requested review from onlydole

@thejoycekung thejoycekung Awaiting requested review from thejoycekung

Assignees

@ameukam ameukam

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
4 participants
@palnabarun @k8s-ci-robot @ameukam @cpanato