Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go] Build go1.17.5 and go1.16.12 images #2351

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Dec 10, 2021

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

Build image using go1.17.5 and go1.16.12

/assign @puerco @saschagrunert @Verolop @justaugustus @xmudrii
/cc @kubernetes/release-engineering

Which issue(s) this PR fixes:

Part of #2349

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[go] Build go1.17.5 and go1.16.12 images

@k8s-ci-robot k8s-ci-robot requested a review from a team December 10, 2021 11:02
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 10, 2021
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/area release-eng/security

updated here as well to the newest release, not sure if that is ok, just to confirm

@cpanato -- Yep, that's fine!

@k8s-ci-robot k8s-ci-robot added area/release-eng/security Issues or PRs related to release engineering security lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 10, 2021
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,justaugustus,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member Author

cpanato commented Dec 10, 2021

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority labels Dec 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit e00305c into kubernetes:master Dec 10, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Dec 10, 2021
@cpanato cpanato deleted the goupdates branch December 10, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng/security Issues or PRs related to release engineering security area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants