-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
relnotes: Sleep when hitting the secondary GH limit #2324
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: puerco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The last couple of releases have been hitting a new secondary rate limit in the GitHub API. This PR makes some changes to play a bit more fair with the API. Now, the notes gatherer interprets the GitHub API responde. If the secondary rate limit was hit, the functions that make a lot of calls will now sleep for a minute+random before respawning. Fixes 2225 Fixes 2302 Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This PR adds the retry capability to the notes package. The permanent fix is here: Merging this should enable us to cut the next beta and patches and we can revert it once |
/lgtm |
@puerco -- This can be fixed more formally with the release of https://github.com/kubernetes-sigs/release-sdk/releases/tag/v0.4.0! 🎉 |
I'll revert to the fix in the package now that the new release is out (once we are done with patch releases) |
What type of PR is this?
/kind bug
/kind failing-test
/kind flake
What this PR does / why we need it:
The last couple of releases have been hitting a new secondary rate limit
in the GitHub API. This PR makes some changes to play a bit more fair with
the API.
Now, the notes gatherer interprets the GitHub API response. If the
secondary rate limit was hit, the functions that make a lot of calls
will now sleep for a minute+random before respawning.
Signed-off-by: Adolfo García Veytia (Puerco) [email protected]
Which issue(s) this PR fixes:
Fixes #2225
Fixes #2302
/priority critical-urgent
/assign @justaugustus @Verolop @palnabarun @saschagrunert
/cc @kubernetes/release-engineering
/milestone v1.23
Special notes for your reviewer:
Note: this functionality should go into the
github
package in release-sdk (looking into this)Does this PR introduce a user-facing change?