Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add go-runner to debian-iptables image #2301

Merged
merged 3 commits into from
Nov 10, 2021

Conversation

BenTheElder
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds the go-runner binary from the go-runner image to debian-iptables.

See background: kubernetes/kubernetes#106086

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

debian-iptables image now contains /go-runner binary

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 2, 2021
@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Nov 2, 2021
dependencies.yaml Outdated Show resolved Hide resolved
@BenTheElder BenTheElder force-pushed the iptables-runner branch 2 times, most recently from f08d9d7 to 080fe50 Compare November 2, 2021 19:00
@BenTheElder
Copy link
Member Author

time="2021-11-02T19:12:37Z" level=info msg="Hit the rate limit on try 1, sleeping for 30m11.860280378s" err="GET https://api.github.com/repos/kubernetes/kubernetes/tags?page=12&per_page=50: 403 API rate limit of 60 still exceeded until 2021-11-02 19:42:49 +0000 UTC, not making remote request. [rate reset in 30m12s]"

unrelated flake.
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/release/2301/pull-release-integration-test/1455613165369823232
/retest

@pohly
Copy link
Contributor

pohly commented Nov 4, 2021

This looks good to me, but I am not familiar with these build rules. Can someone help to get this merged?

While working on kubernetes/kubernetes#106103 I learned that the current kubemark binary needs a libc, so it can't use the existing go-runner image. debian-iptables sounds like a suitable base image.

@puerco
Copy link
Member

puerco commented Nov 7, 2021

Thanks Ben!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 7, 2021
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold we need to bump the debian-iptables image version here as well

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2021
@dims
Copy link
Member

dims commented Nov 8, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2021
@BenTheElder
Copy link
Member Author

will fix that later today!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 9, 2021
@pohly
Copy link
Contributor

pohly commented Nov 9, 2021

@justaugustus is this okay now? If yes, please cancel the hold and LGTM.

It looks okay to me, but I don't know this area.

Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenTheElder -- I've added some code suggestions to update to go1.17.3, now that it's out (#2305).

I'll commit them and get this merged as soon as I hit submit on this review 🙃

dependencies.yaml Outdated Show resolved Hide resolved
images/build/debian-iptables/Makefile Outdated Show resolved Hide resolved
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims, justaugustus, puerco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justaugustus,puerco]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b7bf468 into kubernetes:master Nov 10, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 10, 2021
@@ -13,6 +13,7 @@
# limitations under the License.

ARG BASEIMAGE
ARG GORUNNERIMAGE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, now that I look at how this is getting used in k/k master I realize that a similar change is probably also needed for bullseye/Dockerfile, right?

Let me try to come up with a PR...

pohly added a commit to pohly/release that referenced this pull request Nov 10, 2021
kubernetes#2301 did the same for the buster
image, but Kubernetes master (= 1.23) uses the debian-iptables:bullseye-v1.0.0
image, so the same change is also needed there.
pohly added a commit to pohly/release that referenced this pull request Nov 10, 2021
kubernetes#2301 did the same for the buster
image, but Kubernetes master (= 1.23) uses the debian-iptables:bullseye-v1.0.0
image, so the same change is also needed there.
@BenTheElder BenTheElder deleted the iptables-runner branch November 10, 2021 19:26
@BenTheElder
Copy link
Member Author

Thanks folks (also #2310)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants