-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add go-runner to debian-iptables image #2301
Conversation
f08d9d7
to
080fe50
Compare
080fe50
to
ed5c860
Compare
unrelated flake. |
This looks good to me, but I am not familiar with these build rules. Can someone help to get this merged? While working on kubernetes/kubernetes#106103 I learned that the current kubemark binary needs a libc, so it can't use the existing go-runner image. debian-iptables sounds like a suitable base image. |
Thanks Ben! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold we need to bump the debian-iptables image version here as well
/lgtm |
will fix that later today! |
@justaugustus is this okay now? If yes, please cancel the hold and LGTM. It looks okay to me, but I don't know this area. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BenTheElder -- I've added some code suggestions to update to go1.17.3, now that it's out (#2305).
I'll commit them and get this merged as soon as I hit submit on this review 🙃
Signed-off-by: Stephen Augustus <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, dims, justaugustus, puerco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -13,6 +13,7 @@ | |||
# limitations under the License. | |||
|
|||
ARG BASEIMAGE | |||
ARG GORUNNERIMAGE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, now that I look at how this is getting used in k/k master I realize that a similar change is probably also needed for bullseye/Dockerfile, right?
Let me try to come up with a PR...
kubernetes#2301 did the same for the buster image, but Kubernetes master (= 1.23) uses the debian-iptables:bullseye-v1.0.0 image, so the same change is also needed there.
kubernetes#2301 did the same for the buster image, but Kubernetes master (= 1.23) uses the debian-iptables:bullseye-v1.0.0 image, so the same change is also needed there.
Thanks folks (also #2310) |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds the go-runner binary from the go-runner image to debian-iptables.
See background: kubernetes/kubernetes#106086
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?