Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate pkg/object and pkg/gcp/gcp.go to sigs.k8s.io/release-sdk #2232

Merged
merged 3 commits into from
Aug 31, 2021

Conversation

justaugustus
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

To prepare to move the promotion tooling back to the CIP repo, we need to detangle some dependencies to ensure there aren't import cycles.

kubernetes-sigs/release-sdk#2 pull the following packages/files into sigs.k8s.io/release-sdk:

  • pkg/object
  • pkg/gcp/gcp.go

This PR removes the local copies.

  • Remove pkg/object and pkg/gcp/gcp.go
  • Update import paths to use sigs.k8s.io/release-sdk
  • generated: Run go mod tidy

Part of kubernetes/k8s.io#2624.

Signed-off-by: Stephen Augustus [email protected]

/assign @ameukam @cpanato @saschagrunert @puerco
cc: @kubernetes/release-engineering

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Migrate `pkg/object` and `pkg/gcp/gcp.go` to sigs.k8s.io/release-sdk

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 31, 2021
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 31, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Aug 31, 2021
@puerco
Copy link
Member

puerco commented Aug 31, 2021

Thanks for the huge update Stephen!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3224e8e into kubernetes:master Aug 31, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants