-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[go1.17] Default to go1.17 #2223
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
da8fff3
to
5d6594f
Compare
I expect the remaining tests to pass, but needs kubernetes/test-infra#23362 to fix this failure: ./hack/verify-go-mod.sh
go mod tidy: go.mod file indicates go 1.17, but maximum supported version is 1.16
make: *** [Makefile:52: verify-go-mod] Error 1 EDIT: Confirmed that |
Signed-off-by: Stephen Augustus <[email protected]>
Signed-off-by: Stephen Augustus <[email protected]>
Signed-off-by: Stephen Augustus <[email protected]>
Signed-off-by: Stephen Augustus <[email protected]>
Signed-off-by: Stephen Augustus <[email protected]>
Signed-off-by: Stephen Augustus <[email protected]>
5d6594f
to
7cab583
Compare
/test pull-release-verify |
@cpanato -- Needs kubernetes/test-infra#23362 to be approved first :) |
/test pull-release-verify https://github.com/kubernetes/test-infra/pull/23362is merged :) |
/test pull-release-image-go-runner |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Stephen!
/lgtm
/hold cancel |
What type of PR is this?
/kind cleanup feature
/area dependency
What this PR does / why we need it:
/hold for #2222
Which issue(s) this PR fixes:
Special notes for your reviewer:
I expect some failures here, either in image building or verify tests; just putting it up for early signal.
Does this PR introduce a user-facing change?