Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go] Build go1.16.7 and go1.15.15 images #2197

Merged
merged 5 commits into from
Aug 6, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Aug 6, 2021

What type of PR is this?

/kind feature
/area dependency release-eng/security

What this PR does / why we need it:

Tracking issue: #2196

  • [go] go1.16.7 and go1.15.15 updates
  • go-runner: Build v2.3.1-go1.16.7-buster.0 and v2.3.1-go1.15.15-buster.0
  • releng-ci: build image for go1.16.6 and go1.15.15
  • kube-cross: Build v1.16.7-1 and v1.15.15-1 images
  • kubepkg/packages-deb: update base image to go1.16.7
  • k8s-cloud-builder: Build v1.16.7-1 / v1.15.15-1 / v1.15.15-legacy-1 images

/assign @saschagrunert @puerco @justaugustus
cc @kubernetes/release-engineering

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- [go] go1.16.7 and go1.15.15 updates
- go-runner: Build v2.3.1-go1.16.7-buster.0 and v2.3.1-go1.15.15-buster.0
- releng-ci: build image for go1.16.6 and go1.15.15
- kube-cross: Build v1.16.7-1 and v1.15.15-1 images
- kubepkg/packages-deb: update base image to go1.16.7
- k8s-cloud-builder: Build v1.16.7-1 / v1.15.15-1 / v1.15.15-legacy-1 images

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 6, 2021
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes area/release-eng/security Issues or PRs related to release engineering security cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject labels Aug 6, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 6, 2021
@cpanato cpanato changed the title Go116 go115 [go] Build go1.16.7 and go1.15.15 images Aug 6, 2021
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Aug 6, 2021
@cpanato
Copy link
Member Author

cpanato commented Aug 6, 2021

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority labels Aug 6, 2021
@cpanato
Copy link
Member Author

cpanato commented Aug 6, 2021

will check the k8s-cloud-builder, will drop some changes from this PR and open a follow up

Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will check the k8s-cloud-builder, will drop some changes from this PR and open a follow up

Yep. k8s-cloud-builder should not be bumped until after the other images have been promoted and the appropriate changes have been made to master (to prevent drift between the cross env in k/k presubmits and GCB releases).

The only exception to this would be a "next candidate" release, like go1.17rc2 (#2190), where we know the new go version won't be in use yet.

nit: the commit message for releng-ci image should mention go1.16.7, not go1.16.6

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 6, 2021

@cpanato: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
pull-release-image-k8s-cloud-builder f82dd59 link /test pull-release-image-k8s-cloud-builder

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cpanato
Copy link
Member Author

cpanato commented Aug 6, 2021

looks like some rate limit, will wait a bit and retest it

@cpanato
Copy link
Member Author

cpanato commented Aug 6, 2021

/test pull-release-image-go-runner

@cpanato
Copy link
Member Author

cpanato commented Aug 6, 2021

/test pull-release-integration-test

@k8s-ci-robot k8s-ci-robot merged commit 286b0c2 into kubernetes:master Aug 6, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Aug 6, 2021
@cpanato cpanato deleted the go116-go115 branch August 6, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng/security Issues or PRs related to release engineering security area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants