-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[go] Build go1.16.7 and go1.15.15 images #2197
Conversation
Signed-off-by: Carlos Panato <[email protected]>
Signed-off-by: Carlos Panato <[email protected]>
/priority important-soon |
will check the k8s-cloud-builder, will drop some changes from this PR and open a follow up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will check the k8s-cloud-builder, will drop some changes from this PR and open a follow up
Yep. k8s-cloud-builder should not be bumped until after the other images have been promoted and the appropriate changes have been made to master
(to prevent drift between the cross env in k/k presubmits and GCB releases).
The only exception to this would be a "next candidate" release, like go1.17rc2 (#2190), where we know the new go version won't be in use yet.
nit: the commit message for releng-ci image should mention go1.16.7, not go1.16.6
Signed-off-by: Carlos Panato <[email protected]>
Signed-off-by: Carlos Panato <[email protected]>
Signed-off-by: Carlos Panato <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, justaugustus, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@cpanato: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
looks like some rate limit, will wait a bit and retest it |
/test pull-release-image-go-runner |
/test pull-release-integration-test |
What type of PR is this?
/kind feature
/area dependency release-eng/security
What this PR does / why we need it:
Tracking issue: #2196
/assign @saschagrunert @puerco @justaugustus
cc @kubernetes/release-engineering
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?