-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't generate dependency report for release notes draft #2193
Conversation
The report will be added during the release cut, which then contains the most recent version of changed dependencies. This way we can avoid having the report twice in the notes, too. Signed-off-by: Sascha Grunert <[email protected]>
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
@puerco PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold for @puerco review
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sounds good, thanks Sascha! |
What type of PR is this?
/kind api-change
What this PR does / why we need it:
The report will be added during the release cut, which then contains the
most recent version of changed dependencies. This way we can avoid
having the report twice in the notes, too.
Which issue(s) this PR fixes:
Refers to kubernetes/kubernetes#104146
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?