Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/build Golang 1.17rc1 and 1.16.6 images #2168

Merged
merged 4 commits into from
Jul 14, 2021
Merged

Update/build Golang 1.17rc1 and 1.16.6 images #2168

merged 4 commits into from
Jul 14, 2021

Conversation

justaugustus
Copy link
Member

/kind feature
/area dependency release-eng/security

What this PR does / why we need it:

Tracking issue: #2157

  • k8s-ci-builder: Add 1.22 variant, drop 1.18 variant
  • k8s-ci-builder: Add 1.23 variant
  • k8s-ci-builder: Build go1.16.6 images
  • k8s-cloud-builder: Build v1.17.0-rc.1-1 image

Supersedes #2166 to fix a verify failure created by the "next candidate" (go1.17rc1) images.

/assign @puerco @saschagrunert @cpanato @xmudrii
cc: @kubernetes/release-engineering

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- k8s-ci-builder: Add 1.22 variant, drop 1.18 variant
- k8s-ci-builder: Add 1.23 variant
- k8s-ci-builder: Build go1.16.6 images
- k8s-cloud-builder: Build v1.17.0-rc.1-1 image

justaugustus and others added 4 commits July 14, 2021 10:43
@justaugustus
k8s-ci-builder: Add 1.22 variant, drop 1.18 variant
a1bc11c 
Signed-off-by: Stephen Augustus <[email protected]>
@justaugustus
k8s-ci-builder: Add 1.23 variant
b868dc2 
Signed-off-by: Stephen Augustus <[email protected]>
@puerco @justaugustus
k8s-ci-builder: Build go1.16.6 images
817dd10 
This commit modifies the k8s-ci-builder files and
the dependencies.yaml manifest to golang 1.16.6.

Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
Co-authored-by: Stephen Augustus <[email protected]>
@justaugustus
k8s-cloud-builder: Build v1.17.0-rc.1-1 image
99473d2 
Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes area/release-eng/security Issues or PRs related to release engineering security release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jul 14, 2021
@k8s-ci-robot k8s-ci-robot requested review from puerco and xmudrii July 14, 2021 15:12
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 14, 2021
@justaugustus justaugustus mentioned this pull request Jul 14, 2021
Closed
cpanato
cpanato approved these changes Jul 14, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold for more eyes if needed

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jul 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,justaugustus,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,justaugustus,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Member Author

/hold cancel
(Since Sascha has approved as well.)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit a1aca71 into kubernetes:master Jul 14, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 14, 2021
@justaugustus justaugustus mentioned this pull request Jul 14, 2021
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@puerco puerco Awaiting requested review from puerco

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@saschagrunert saschagrunert

@puerco puerco

@cpanato cpanato

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng/security Issues or PRs related to release engineering security area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.22
Development

Successfully merging this pull request may close these issues.
6 participants
@justaugustus @k8s-ci-robot @saschagrunert @cpanato @puerco @xmudrii