Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packages/deb: Use ci/latest.txt as canonical cross build marker #2153

Merged
merged 1 commit into from
Jul 3, 2021

Conversation

justaugustus
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

As of kubernetes/k8s.io#1857, https://dl.k8s.io/ci now redirects to Kubernetes Community infra (gs://k8s-release-dev) instead of Google-owned infra (gs://kubernetes-release-dev).

We also removed ci-cross version markers, which are:

  1. no longer built
  2. redundant, as compared with https://dl.k8s.io/ci/latest.txt

Here we update references to https://dl.k8s.io/ci-cross with https://dl.k8s.io/ci

Part of #1711 and kubernetes/k8s.io#1569.

Signed-off-by: Stephen Augustus [email protected]

/assign @puerco @cpanato @saschagrunert
cc: @kubernetes/release-engineering @kubernetes/build-admins

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- packages/deb: Use ci/latest.txt as canonical cross build marker

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 3, 2021
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Jul 3, 2021
@k8s-ci-robot k8s-ci-robot requested review from amwat and xmudrii July 3, 2021 03:31
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 3, 2021
@BenTheElder
Copy link
Member

@kubernetes/build-admins

This tool isn't used currently? 🤔

@justaugustus
Copy link
Member Author

@kubernetes/build-admins

This tool isn't used currently? 🤔

We do 🙃

publish_debs() {
local distro=xenial
log "Clearing output dir"
rm -rf packages/deb/bin
cd packages/deb
log "Setting all Revisions to \"00\" in build.go"
sed -i -r -e 's/\b(Revision:\s*)"[0-9]{2}"/\1"00"/' build.go
log "Building debs for Kubernetes v${version}"
./jenkins.sh --kube-version $version --distros $distro
log "Changing file owner from root to ${USER}"
sudo chown -R "${USER}" bin
log "Removing local debs that already exist on the server"
local debpath
for debfile in $(rapture --universe=cloud-apt listrepo "kubernetes-${distro}" | sed -r -e 's/^(\S+) (\S+) \[(\S+)\] .*$/\1_\2_\3.deb/'); do
debpath="bin/stable/${distro}/${debfile}"
if [[ -f "${debpath}" ]]; then
log "Removing ${debpath}"
rm "${debpath}"
fi
done
if ls bin/stable/${distro}/*.deb 1> /dev/null 2>&1;
then
log "Pushing debs to kubernetes-${distro}-unstable"
rapture --universe=cloud-apt addpkg -keepold "kubernetes-${distro}" bin/stable/${distro}/*.deb
else
log "No debs found in bin/stable/${distro}/*.deb, skipping rapture addpkg"
fi
log "Packages in kubernetes-${distro}-unstable:"
rapture --universe=cloud-apt listrepo "kubernetes-${distro}-unstable"
local target
target=$(rapture --universe=cloud-apt showrepo "kubernetes-${distro}-unstable" | awk '/ Current indirection:/ {print $3}')
log
log "Promoting ${target} to stable"
rapture --universe=cloud-apt settag "${target}" cloud-kubernetes-release.stable:true
cd ${release_dir}
}

Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 88533d5 into kubernetes:master Jul 3, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 3, 2021
@BenTheElder
Copy link
Member

We do 🙃

I don't see anywhere in this snippet that calls into the code touched in this PR? what am I missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants