Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build images using golang 1.15.8 #1896

Merged
merged 4 commits into from
Feb 5, 2021
Merged

Build images using golang 1.15.8 #1896

merged 4 commits into from
Feb 5, 2021

Conversation

puerco
Copy link
Member

@puerco puerco commented Feb 5, 2021

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

Go 1.15.8 was released on Feb 4th 2021: https://groups.google.com/g/golang-announce/c/rUbPPotvaFM

This PR bumps the golang version to 1.15.8 in the following images: kube-cross, go-runner, vulndash, releng-ci

Which issue(s) this PR fixes:

Part of #1895

Special notes for your reviewer:

My first attempt at a golang bump. I built this PR following @ameukam's work on 1.15.7

Does this PR introduce a user-facing change?

Golang bump to 1.15.8 resulting in the following new images:
- kube-cross:v1.15.8-1
- go-runner:buster-v2.3.1
- vulndash:v0.4.3-3
- releng-ci:v0.2.1

puerco added 3 commits February 4, 2021 20:48
@puerco
vulndash: Image v0.4.3-3 (golang 1.15.8)
66aab17 
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
@puerco
Build go-runner:buster-v2.3.1 (golang 1.15.8)
612be89 
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
@puerco
Build releng-ci:v0.2.1 (golang 1.15.8)
fa4ead3 
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject labels Feb 5, 2021
@k8s-ci-robot k8s-ci-robot requested a review from cpanato February 5, 2021 03:26
@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Feb 5, 2021
@k8s-ci-robot k8s-ci-robot requested a review from dims February 5, 2021 03:26
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 5, 2021
@puerco
Copy link
Member Author

puerco commented Feb 5, 2021

/test pull-release-image-kube-cross

@puerco
Build kubecross:v1.15.8-1 (golang 1.15.8)
109b20d 
Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
@saschagrunert
Copy link
Member

/test pull-release-image-kube-cross

@saschagrunert
Copy link
Member

Ah yeah the service account does not exist. @cpanato may have more insights into this kind of issue.

saschagrunert
saschagrunert approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for possible suggestions about the CI.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2021
@cpanato
Copy link
Member

cpanato commented Feb 5, 2021

the job pull-release-image-kube-cross can be ignored, for now, this is working in progress and we have some discussions in how to deal here: kubernetes/test-infra#20703

cpanato
cpanato approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I think that is okay to push back from 1.16 to 1.5, maybe we need to redo the 1.16 again

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, puerco, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato cpanato mentioned this pull request Feb 5, 2021
Closed
20 tasks
@cpanato cpanato added this to the v1.21 milestone Feb 5, 2021
@cpanato
Copy link
Member

cpanato commented Feb 5, 2021

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority labels Feb 5, 2021
@cpanato
Copy link
Member

cpanato commented Feb 5, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit 9e85656 into kubernetes:master Feb 5, 2021
cpanato
cpanato reviewed Feb 5, 2021
View reviewed changes
images/build/cross/variants.yaml
@@ -1,8 +1,8 @@
variants:
canary:
CONFIG: 'canary'
GO_VERSION: '1.16rc1'
IMAGE_VERSION: 'v1.16.0-rc.1-canary-1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now looking at it again, i think this should stay as 1.16 , will revert this part

@cpanato cpanato mentioned this pull request Feb 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@dims dims Awaiting requested review from dims

Assignees

@saschagrunert saschagrunert

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
4 participants
@puerco @saschagrunert @cpanato @k8s-ci-robot