pkg/build: Validate images exist before proceeding with CI builds #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Augustus <[email protected]>
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/release-eng
hasheddan
reviewed
Nov 11, 2020
pkg/release/images.go
Outdated
| @@ -239,6 +239,89 @@ func (i *Images) Validate(registry, version, buildPath string) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // Exists that image manifests exist on a specified remote registry. | |||
There was a problem hiding this comment.
Nitpick:
Suggested change
| // Exists that image manifests exist on a specified remote registry. | |
| // Checks that image manifests exist on a specified remote registry. |
saschagrunert
approved these changes
Nov 11, 2020
pkg/release/images.go
Outdated
| @@ -239,6 +239,89 @@ func (i *Images) Validate(registry, version, buildPath string) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // Exists that image manifests exist on a specified remote registry. | |||
There was a problem hiding this comment.
I guess the intention is to keep the convention to start the docs with the method name, for example:
Suggested change
| // Exists that image manifests exist on a specified remote registry. | |
| // Exists verifies that an image manifests exist on a specified remote registry. |
There was a problem hiding this comment.
Yep, that was my goal! And then I threw in some bad grammar to make it interesting 😅
k8s-ci-robot
added
do-not-merge/hold
Signed-off-by: Stephen Augustus <[email protected]>
Signed-off-by: Stephen Augustus <[email protected]>
justaugustus
force-pushed
the
krel-ci-build
branch
from
faf37c0 to
0f4b6e3
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Continuation of #1710.
Part of #1711.
/assign @hasheddan @saschagrunert
cc: @kubernetes/release-engineering
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?