Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup some CI build logic and add k8s-ci-builder image #1700

Merged
merged 6 commits into from
Nov 10, 2020
Merged

Cleanup some CI build logic and add k8s-ci-builder image #1700

merged 6 commits into from
Nov 10, 2020

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Nov 9, 2020 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Add k8s-ci-builder image to support Kubernetes builds in CI
    Follow-up to [krel] Initial commit krel ci-build command #1698
  • k8s-ci-builder: Short-circuit logic building by using krte image
  • pkg/build: Cleanup some CI flags and build requirements
  • pkg/build: Don't rewrite bucket in build Instance
  • pkg/build: Consolidate build type / directory setting logic
  • pkg/build: Properly handle extra version markers

Which issue(s) this PR fixes:

Special notes for your reviewer:

I'm still wrestling with the GCB config file, but I was able to push this locally to support testing with kubernetes/test-infra#19887.

Does this PR introduce a user-facing change?

- Add k8s-ci-builder image to support Kubernetes builds in CI
- k8s-ci-builder: Short-circuit logic building by using krte image 
- pkg/build: Cleanup some CI flags and build requirements
- pkg/build: Don't rewrite bucket in build Instance
- pkg/build: Consolidate build type / directory setting logic
- pkg/build: Properly handle extra version markers

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 9, 2020
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 9, 2020
@justaugustus justaugustus mentioned this pull request Nov 9, 2020
Merged
@justaugustus justaugustus force-pushed the krel-ci-build branch 2 times, most recently from 5c5bb75 to 34dbaf0 Compare November 10, 2020 00:54
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 10, 2020
@justaugustus justaugustus force-pushed the krel-ci-build branch 2 times, most recently from e0dfbb1 to cb5d4df Compare November 10, 2020 10:52
@justaugustus justaugustus changed the title [WIP] Add k8s-ci-builder image to support Kubernetes builds in CI Cleanup some CI build logic and add k8s-ci-builder image Nov 10, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 10, 2020
@justaugustus
Copy link
Member Author

This is now passing consistently in CI --> https://prow.k8s.io/?job=ci-kubernetes-build-no-bootstrap

/assign @saschagrunert @cpanato @xmudrii
cc: @kubernetes/release-engineering

saschagrunert
saschagrunert approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2020
xmudrii
xmudrii approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cpanato
cpanato approved these changes Nov 10, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

hasheddan
hasheddan approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, hasheddan, justaugustus, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • cmd/krel/OWNERS [cpanato,hasheddan,justaugustus,saschagrunert,xmudrii]
  • images/OWNERS [cpanato,hasheddan,justaugustus,saschagrunert,xmudrii]
  • pkg/OWNERS [cpanato,hasheddan,justaugustus,saschagrunert,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f2f4baa into kubernetes:master Nov 10, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 10, 2020
This was referenced Nov 10, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@xmudrii xmudrii xmudrii approved these changes

@cpanato cpanato cpanato approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

@hoegaarden hoegaarden Awaiting requested review from hoegaarden

Assignees

@saschagrunert saschagrunert

@cpanato cpanato

@xmudrii xmudrii

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
6 participants
@justaugustus @k8s-ci-robot @saschagrunert @cpanato @xmudrii @hasheddan