Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move krel push logic into release API #1579

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Move krel push logic into release API #1579

merged 1 commit into from
Sep 23, 2020

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

This allows us to re-use the same logic in other golang projects like
kubetest.

Which issue(s) this PR fixes:

Refers to #1578

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 23, 2020
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 23, 2020
@saschagrunert saschagrunert mentioned this pull request Sep 23, 2020
Closed
4 tasks
justaugustus
justaugustus requested changes Sep 23, 2020
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit; LGTM otherwise

pkg/release/push.go Show resolved Hide resolved
@saschagrunert saschagrunert changed the title WIP: Move krel push logic into release API Move krel push logic into release API Sep 23, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 23, 2020
justaugustus
justaugustus reviewed Sep 23, 2020
View reviewed changes
pkg/release/push.go Outdated Show resolved Hide resolved
@saschagrunert
Move krel push logic into release API
b5baa9b 
This allows us to re-use the same logic in other golang projects like
kubetest.

Signed-off-by: Sascha Grunert <[email protected]>
@justaugustus
Copy link
Member

/lgtm
/approve

Thanks for the quick turnaround on integrating this!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ebd41a9 into kubernetes:master Sep 23, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 23, 2020
@saschagrunert saschagrunert deleted the push-build-lib branch September 23, 2020 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus requested changes

@hoegaarden hoegaarden Awaiting requested review from hoegaarden

Assignees

@justaugustus justaugustus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.
3 participants
@saschagrunert @justaugustus @k8s-ci-robot