push-build: Support pushing fast builds to a /fast subdirectory #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(This inverts the logic of a previous commit.) After reviewing the Kubernetes build scenarios and currently configured jobs, it becomes clear that a "fast" build (linux/amd64-only) is a special case. Fast builds only happen on the master branch, which means master version markers are the only ones experiencing collisions. That said, cross builds are the default build type across release branches and we should instead special-case fast builds, giving them their own subdirectory and version markers to leverage. The following markers should be built when an accompanying k/test-infra PR is merged: - latest-fast - latest-1-fast - latest-1.19-fast With fast builds being published to the following location: gs://kubernetes-release-dev/ci/fast/ Signed-off-by: Stephen Augustus <[email protected]>
k8s-ci-robot
added
release-note
|
@justaugustus: Adding label: Reasons for blocking this PR:[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.] Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
kind/bug
k8s-ci-robot
added
sig/release
justaugustus
removed
the
do-not-merge/blocked-paths
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, justaugustus, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug cleanup
What this PR does / why we need it:
(Follow-up to #1387, #1386, and #1385.)
(This inverts the logic of a previous commit --> 1e56e60)
After reviewing the Kubernetes build scenarios and currently configured
jobs, it becomes clear that a "fast" build (linux/amd64-only) is a
special case.
Fast builds only happen on the master branch, which means master version
markers are the only ones experiencing collisions.
That said, cross builds are the default build type across release
branches and we should instead special-case fast builds, giving them
their own subdirectory and version markers to leverage.
The following markers should be built when an accompanying k/test-infra
PR is merged:
latest-fastlatest-1-fastlatest-1.19-fastWith fast builds being published to the following location:
gs://kubernetes-release-dev/ci/fast/
Signed-off-by: Stephen Augustus [email protected]
/assign @tpepper @hasheddan @saschagrunert @cpanato
cc: @kubernetes/release-engineering @BenTheElder @spiffxp
ref: kubernetes/sig-release#850, kubernetes/sig-release#759
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?