-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should release-notify script send from GCB? #959
Comments
Yes, I think it should. Directly sending does not work, however sending mails via sendgrid works (other services will most probably work too, but that's what I have been using eg. in #949). From what I can see, things we'd need to make this a reality:
|
@hoegaarden -- Since you've already been working on this, I'm assigning you. Let's see if we have time in the releng meeting today to discuss. /assign @hoegaarden |
To add some context here: See also: |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@hoegaarden @justaugustus I see that this issue is rotten and in the v1.18 milestone. Should we do anything about that? |
/milestone v1.19 |
I signed up for a Sendgrid account for this a while back, but it hasn't been high-priority. /assign |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
@justaugustus is this still relevant to us? Manually announcing the release seems a legit step to me. |
Closing because I guess the process we're using right now is a great fit. I do not see a necessity to announce directly from krel. |
@saschagrunert: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
(Follow-up item from kubernetes/sig-release#696)
ref: kubernetes/sig-release#666 (comment)
cc: @hoegaarden @tpepper @kubernetes/patch-release-team
/help
/sig release
/area release-eng
/milestone v1.18
/priority important-longterm
/kind feature
The text was updated successfully, but these errors were encountered: