Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should release-notify script send from GCB? #959

Closed
justaugustus opened this issue Dec 9, 2019 · 13 comments
Closed

Should release-notify script send from GCB? #959

justaugustus opened this issue Dec 9, 2019 · 13 comments
Assignees
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/release Categorizes an issue or PR as relevant to SIG Release.
Milestone

Comments

@justaugustus
Copy link
Member

(Follow-up item from kubernetes/sig-release#696)
ref: kubernetes/sig-release#666 (comment)

cc: @hoegaarden @tpepper @kubernetes/patch-release-team

/help
/sig release
/area release-eng
/milestone v1.18
/priority important-longterm
/kind feature

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Dec 9, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Dec 9, 2019
@k8s-ci-robot k8s-ci-robot added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. area/release-eng Issues or PRs related to the Release Engineering subproject priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 9, 2019
@hoegaarden
Copy link
Contributor

Should release-notify script send from GCB?

Yes, I think it should.

Directly sending does not work, however sending mails via sendgrid works (other services will most probably work too, but that's what I have been using eg. in #949).

From what I can see, things we'd need to make this a reality:

  • a sendgrid account
  • a sendgrid secret in GCB (similar to the already existing one for the GitHub token)
  • changes to the notify script to run on GCB and not locally

@justaugustus
Copy link
Member Author

@hoegaarden -- Since you've already been working on this, I'm assigning you. Let's see if we have time in the releng meeting today to discuss.

/assign @hoegaarden
/remove-help

@k8s-ci-robot k8s-ci-robot removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Dec 9, 2019
@hoegaarden
Copy link
Contributor

To add some context here:
Sending mails is not directly possible from a GCP instance because the default smtp port is blocked. There are some workarounds and alternatives. Using a service like sendgrid seems to be the easiest.

See also:

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 9, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 8, 2020
@xmudrii
Copy link
Member

xmudrii commented May 7, 2020

@hoegaarden @justaugustus I see that this issue is rotten and in the v1.18 milestone. Should we do anything about that?

@xmudrii
Copy link
Member

xmudrii commented May 11, 2020

/milestone v1.19
/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 11, 2020
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.18, v1.19 May 11, 2020
@justaugustus
Copy link
Member Author

I signed up for a Sendgrid account for this a while back, but it hasn't been high-priority.
Will try to close the loop on this this cycle.

/assign

@justaugustus justaugustus added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels May 13, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 11, 2020
@saschagrunert
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 11, 2020
@saschagrunert
Copy link
Member

@justaugustus is this still relevant to us? Manually announcing the release seems a legit step to me.

@saschagrunert
Copy link
Member

Closing because I guess the process we're using right now is a great fit. I do not see a necessity to announce directly from krel.
/close

@k8s-ci-robot
Copy link
Contributor

@saschagrunert: Closing this issue.

In response to this:

Closing because I guess the process we're using right now is a great fit. I do not see a necessity to announce directly from krel.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

6 participants