Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency update - Golang 1.16 #1834

Closed
20 of 21 tasks
justaugustus opened this issue Jan 8, 2021 · 10 comments
Closed
20 of 21 tasks

Dependency update - Golang 1.16 #1834

justaugustus opened this issue Jan 8, 2021 · 10 comments
Assignees
Labels
area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release.
Milestone

Comments

@justaugustus
Copy link
Member

justaugustus commented Jan 8, 2021

Tracking info

go1.16 was released on 2/16: https://groups.google.com/g/golang-announce/c/q-exD-8mG3w
go1.16rc1 was released on 1/28: https://groups.google.com/g/golang-announce/c/U_FUHY4wuSc
go1.16beta1 was released on 12/17: https://groups.google.com/g/golang-announce/c/2-Rj3P5uRLs

As Kubernetes 1.20 has already been released, we can get started on pulling in the Golang prereleases.

Golang mailing list announcement:

SIG Release Slack thread: https://kubernetes.slack.com/archives/C2C40FMNF/p1610074100305000

Pre-work: k/repo-infra updates

Work items for go1.16rc1

During kube-cross image promotion

After kube-cross image promotion

  • kubernetes/kubernetes update (master): [go1.16] Update to go1.16 kubernetes#98572

    Ensure the following have been updated within the PR:

    • rules_go No longer required as bazel has been removed
    • kube-cross image
    • go-runner image
    • publishing bot rules

After kubernetes/kubernetes has been updated

Cherry picks

N/A

Follow-up items

  • Ensure the Golang issue template is updated with any new requirements

/assign
cc: @kubernetes/release-engineering

@justaugustus justaugustus added kind/feature Categorizes issue or PR as related to a new feature. sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject area/dependency Issues or PRs related to dependency changes labels Jan 8, 2021
@justaugustus justaugustus added this to the v1.21 milestone Jan 8, 2021
@justaugustus justaugustus added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jan 8, 2021
@liggitt
Copy link
Member

liggitt commented Jan 8, 2021

cc @kubernetes/sig-scalability @wojtek-t in case there are any scale impacts we should be keeping an eye on

@wojtek-t
Copy link
Member

wojtek-t commented Jan 8, 2021

There seem to be some regression in early December. We're working with golang folks to figure that out.
@tosi3k - can you please file an issue for that so that it's possible to track it?

@tosi3k
Copy link
Member

tosi3k commented Jan 8, 2021

Done: kubernetes/kubernetes#97846.

@justaugustus
Copy link
Member Author

(I'll start moving on this again once go1.16rc1 is out. signal: golang/go#43253)

There seem to be some regression in early December. We're working with golang folks to figure that out.
@tosi3k - can you please file an issue for that so that it's possible to track it?

@wojtek-t @tosi3k -- Any updates re: this (👇🏾) regression?

Done: kubernetes/kubernetes#97846.

@justaugustus
Copy link
Member Author

Echoing the scalability update from kubernetes/kubernetes#97846 (comment):

It seems we're mostly understanding the issue - we're trying to confirm last remaining details.

But the bottomline is that it doesn't seem to be golang-related - golang seem to be fine.

We will update the issue once we confirm the remaining details.

and kubernetes/kubernetes#97846 (comment):

To add a bit more details to it - there were some internal changes which resulted in some underlying machine architecture having much more predictible networking characteristics than others.

With our jobs requiring high predictability, the recommendation from Google networking engineers was to simply migrate the jobs to new enough architecture (Skylake+) which we did in: kubernetes/test-infra#20584

And that fixed our problems.

Closing this one as addressed.

@nikhita
Copy link
Member

nikhita commented Mar 2, 2021

go 1.16 tripped the publishing-bot: kubernetes/kubernetes#56876 (comment)

Looks like it's hitting golang/go#44129 or something similar. I'll take a look at this tomorrow.

@justaugustus
Copy link
Member Author

Thanks @nikhita! Keep us posted :)

@nikhita
Copy link
Member

nikhita commented Mar 3, 2021

Looks like it's hitting golang/go#44129 or something similar. I'll take a look at this tomorrow.

Created kubernetes/kubernetes#99674 to fix this

@justaugustus
Copy link
Member Author

We're all set here.
go1.16.1 tracking is here: #1936

/close

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Closing this issue.

In response to this:

We're all set here.
go1.16.1 tracking is here: #1936

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus justaugustus unpinned this issue Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

6 participants