Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s-staging-kubernetes GCB service account needs access to Google staging/prod GCS and GCR #1176

Closed
1 of 2 tasks
justaugustus opened this issue Mar 11, 2020 · 5 comments
Closed
1 of 2 tasks
Assignees
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@justaugustus
Copy link
Member

What would you like to be added:

The k8s-staging-kubernetes GCB service account ([email protected]) needs access to write to GCS buckets in Google-infra staging and production projects.

  • Staging access (kubernetes-release-test project)
    • @justaugustus - Granted the svc account Storage Admin for staging
  • Production access (google-containers project)

Why is this needed:

We're moving GCB jobs to run in the new staging projects as an intermediary step before the k8s.gcr.io vanity domain flip (#270), so the k8s-staging-kubernetes GCB service account will need the same permissions to write to GCS and GCR as the kubernetes-release-test GCB account does.

@justaugustus justaugustus added kind/feature Categorizes issue or PR as related to a new feature. sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels Mar 11, 2020
@justaugustus
Copy link
Member Author

/assign @justaugustus @listx

@thockin
Copy link
Member

thockin commented Mar 11, 2020

From Slack DM w/ @thockin, @justaugustus, @listx, @tpepper:

"A domain restriction organization policy is in place. Only members of allowed domains can be added as members of the policy"

This is why we need to move to community hands. The existing permission predates the policy enforcement.

We can leave the GCB in the existing project and let that push to new staging GCR and old GCS (since that grant exists) and use that as fuel to justify the GCS promotion process or at least an equivalent backfill-and-VDF process to new-prod GCS

@justaugustus
Copy link
Member Author

Closed as WONTFIX, based on the domain restriction policy.
We'll wait until dl.k8s.io is cut over and proceed from there.

@justaugustus
Copy link
Member Author

/close

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

justaugustus added a commit to justaugustus/k8s.io that referenced this issue Mar 19, 2020
Grant the 'kubernetes-release-test' Cloud Build account write access to
the container artifacts GCS location for 'k8s-staging-kubernetes'
('gs://artifacts.k8s-staging-kubernetes.appspot.com').

This currently is a requirement as a domain restriction organization
policy is in place on the Google Infra projects, which prevents us from
completely moving staging to K8s Infra until dl.k8s.io is moved as well.

ref: kubernetes/release#1176

Signed-off-by: Stephen Augustus <[email protected]>
justaugustus added a commit to justaugustus/k8s.io that referenced this issue Mar 19, 2020
Grant the 'kubernetes-release-test' Cloud Build account write access to
the container artifacts GCS location for 'k8s-staging-kubernetes'
('gs://artifacts.k8s-staging-kubernetes.appspot.com').

This currently is a requirement as a domain restriction organization
policy is in place on the Google Infra projects, which prevents us from
completely moving staging to K8s Infra until dl.k8s.io is moved as well.

ref: kubernetes/release#1176

Signed-off-by: Stephen Augustus <[email protected]>
justaugustus added a commit to justaugustus/k8s.io that referenced this issue Mar 19, 2020
Grant the 'kubernetes-release-test' Cloud Build account write access to
the container artifacts GCS location for 'k8s-staging-kubernetes'
('gs://artifacts.k8s-staging-kubernetes.appspot.com').

This currently is a requirement as a domain restriction organization
policy is in place on the Google Infra projects, which prevents us from
completely moving staging to K8s Infra until dl.k8s.io is moved as well.

ref: kubernetes/release#1176

Signed-off-by: Stephen Augustus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject kind/feature Categorizes issue or PR as related to a new feature. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

4 participants