iterate on geranos MVP #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make dry-run configurable, throttle concurrency more, fix keys, skip existing layers by default
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
BenTheElder
requested review from
justinsb
and removed request for
BobyMCbobs
TerryHowe
reviewed
Feb 23, 2023
|
|
||
| repo, err := name.NewRepository(sourceRegistry) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| s3Uploader, err := newS3Uploader() | ||
| s3Uploader, err := newS3Uploader(os.Getenv("REALLY_UPLOAD") == "") |
There was a problem hiding this comment.
Suggested change
| s3Uploader, err := newS3Uploader(os.Getenv("REALLY_UPLOAD") == "") | |
| s3Uploader, err := newS3Uploader(os.Getenv("DRY_RUN") != "") |
I'm new here, so maybe this makes more sense to everyone else.
There was a problem hiding this comment.
The default for now is to do a dry run. This would invert that default.
| dryRun bool | ||
| svc *s3.S3 | ||
| uploader *s3manager.Uploader | ||
| reuploadLayers bool |
There was a problem hiding this comment.
Doesn't look like this is used
There was a problem hiding this comment.
It is read. It is not yet written.
|
LGTM /lgtm |
k8s-ci-robot
added
the
lgtm
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
couple quick follow-ups that should be enough to get a test job running:
make dry-run configurable
throttle concurrency more ref #153
fix s3 bucket / keys
skip existing layers by default