Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert registry to k8s.gcr.io #88

Merged
merged 1 commit into from
Dec 28, 2017
Merged

Conversation

thockin
Copy link
Member

@thockin thockin commented Dec 22, 2017

This PR was auto-generated. Please apply human expertise to review for correctness.

Followup to kubernetes/kubernetes#54174

xref kubernetes/release#281

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 22, 2017
@gmarek
Copy link

gmarek commented Dec 28, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 28, 2017
@gmarek gmarek merged commit 32170dd into kubernetes:master Dec 28, 2017
@@ -14,7 +14,7 @@

ARCH ?= amd64
TAG ?= 1.0
REGISTRY ?= gcr.io/google_containers
REGISTRY ?= k8s.gcr.io

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REGISTRY ?= staging-k8s.gcr.io

Don't know how authentication is done here, e.g. if it assumes that a cred helper is installed so that naked docker just works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants