Add members 20240403 #4869
Add members 20240403 #4869
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
approved
|
/lgtm Remove the hold when you are ready. |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
@mrbobbytables |
|
@sivchari its both! I've edited the description to reflect that, thanks. |
| description: Bots that only have admin access to staged repositories. Giving admin | ||
| access to other repositories may allow the bot to automatically unintentionally | ||
| close issues in those repositories. | ||
| description: Bots that only have admin access to staged repositories. Giving admin access to other repositories may allow the bot to automatically unintentionally close issues in those repositories. |
There was a problem hiding this comment.
Is this diff unintentional?
There was a problem hiding this comment.
Same question for the other similar ones above.
There was a problem hiding this comment.
it was. TBH - I'm not sure where it came from. I thought I only ran korg add commands unless it auto-formatted them Will poke around a bit
There was a problem hiding this comment.
I did a test and replicated the same behavior with just using the korg command
not sure how we didn’t see this before, so something has to have changed somewhere
git checkout main
git fetch upstream
git rebase upstream/main
git checkout -b 'format-test'
korg add seifrajhi --org kubernetes --org kubernetes-sigs --confirm
(person was the first commit in my other branch)
checked diff and it mirrors what I pushed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MadhavJivrajani, mrbobbytables The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
Hi @MadhavJivrajani |
|
@sivchari, Yes. please give it a day? You should get it in a bit. |
|
@jasonbraganza , Thanks. I was just wondering. |
|
It seems the job post-org-peribolos is always timeout after Feb 19. Should we just increase the timeout, or investigate why it is so slow? |
|
yes, folks are aware of this issue and work is in progress on figuring this out |
|
@jasonbraganza Do you have any issue number for tracking this? |
fixes: #4827
fixes: #4831
fixes: #4834
fixes: #4835
fixes: #4836
fixes: #4841
fixes: #4845
fixes: #4847
fixes: #4848
fixes: #4855
fixes: #4857
fixes: #4859
fixes: #4860
fixes: #4864
fixes: #4865
fixes: #4866
fixes: #4877
fixes: #4867