Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add members 2022-06-05 #3474

Merged
merged 16 commits into from
Jun 6, 2022

Conversation

mrbobbytables
Copy link
Member

fixes: #3430
fixes: #3446
fixes: #3449
fixes: #3452
fixes: #3453
fixes: #3457
fixes: #3458
fixes: #3459
fixes: #3461
fixes: #3464
fixes: #3465
fixes: #3466
fixes: #3468
fixes: #3469

/area github-membership

@k8s-ci-robot k8s-ci-robot added area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 5, 2022
@k8s-ci-robot k8s-ci-robot requested a review from palnabarun June 5, 2022 22:50
@k8s-ci-robot k8s-ci-robot added the area/github-management Issues or PRs related to GitHub Management subproject label Jun 5, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2022
@mrbobbytables
Copy link
Member Author

/hold

I thought I rebased before starting, guess I didn't -_- 1 min

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2022
@mrbobbytables mrbobbytables force-pushed the add-members-2022-06-05 branch from 8b7913d to be13c21 Compare June 5, 2022 22:55
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2022
@mrbobbytables
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2022
@ameukam
Copy link
Member

ameukam commented Jun 6, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2022
@palnabarun
Copy link
Member

/lgtm
/approve

Thanks Bob!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrbobbytables, palnabarun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mrbobbytables
Copy link
Member Author

prow is having issues right now, it'll get merged eventually.

@k8s-ci-robot k8s-ci-robot merged commit 9f2030e into kubernetes:main Jun 6, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 6, 2022
@ramrodo ramrodo mentioned this pull request Jun 7, 2022
9 tasks
@mrbobbytables mrbobbytables deleted the add-members-2022-06-05 branch September 23, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject area/github-membership Requesting membership in a Kubernetes GitHub Organization or Team cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
4 participants