Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup SIG Testing subteams #2473

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Setup SIG Testing subteams #2473

merged 1 commit into from
Jan 29, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jan 29, 2021 •
edited
Loading

specifically:

  • add sig-testing/sig-testing-leads
  • move sig-testing-pr-reviews under sig-testing

META: this was mostly a PR to verify what creating a new PR from an old local clone looks like following a rename of this repo's default branch

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 29, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/github-management Issues or PRs related to GitHub Management subproject size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 29, 2021
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 29, 2021
@spiffxp spiffxp changed the title testing Setup SIG Testing subteams Jan 29, 2021
@spiffxp
setup sig-testing subteams
bcd863e 
specifically:

- add sig-testing/sig-testing-leads
- move sig-testing-pr-reviews under sig-testing
@spiffxp
Copy link
Member Author

spiffxp commented Jan 29, 2021

/cc @BenTheElder @stevekuznetsov

@spiffxp spiffxp mentioned this pull request Jan 29, 2021
Merged
BenTheElder
BenTheElder reviewed Jan 29, 2021
View reviewed changes
config/kubernetes/sig-testing/teams.yaml
- cjwagner
- clarketm
- ixdy
- Katharine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this list could probably do with some tidying?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, I wanted to do that as a followup

@spiffxp spiffxp mentioned this pull request Jan 29, 2021
Closed
@BenTheElder
Copy link
Member

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jan 29, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit d9a4a97 into kubernetes:main Jan 29, 2021
@spiffxp spiffxp deleted the subteam-sig-testing branch January 29, 2021 20:55
@spiffxp
Copy link
Member Author

spiffxp commented Jan 29, 2021

milestone_applier failed to apply the v1.21 milestone for the non-existant master branch, which is what I expected, but I don't see any errors/logs about this in k8s-prow's logs

@spiffxp
Copy link
Member Author

spiffxp commented Jan 29, 2021

probably because it exits early/silently if main isn't configured, ref: https://github.com/kubernetes/test-infra/blob/4ddcfd375fcd021a16f696aa83b4bbbbd5c9ba91/prow/plugins/milestoneapplier/milestoneapplier.go#L84-L88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@savitharaghunathan savitharaghunathan Awaiting requested review from savitharaghunathan

@stevekuznetsov stevekuznetsov Awaiting requested review from stevekuznetsov

Assignees

@BenTheElder BenTheElder

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spiffxp @k8s-ci-robot @BenTheElder