Update config/systemd-monitor.json to match all systemd StatusUnitFormat #852
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
/assign vteratipally Thanks : ) |
| @@ -13,17 +13,17 @@ | |||
| { | |||
| "type": "temporary", | |||
| "reason": "KubeletStart", | |||
| "pattern": "Started Kubernetes kubelet." | |||
| "pattern": "Started (Kubernetes kubelet|kubelet.service|kubelet.service - Kubernetes kubelet)." | |||
There was a problem hiding this comment.
Is this part actually needed? The first 2 sub-patterns should match also the more complex one if the . at the end is removed.
Same question/suggestion for the other 2 changes
| "pattern": "Started (Kubernetes kubelet|kubelet.service|kubelet.service - Kubernetes kubelet)." | |
| "pattern": "Started (Kubernetes kubelet|kubelet.service)" |
There was a problem hiding this comment.
It is needed, the pattern needs to match the whole line instead of partial as a "\z" is appended to the pattern. See code & comments
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: linxiulei, vteratipally The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
See #849. This should be the last part in NPD that has pattern for systemd logs.