Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct dependency on google/[email protected] #805

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

hakman
Copy link
Member

@hakman hakman commented Sep 8, 2023

The tail functionality was removed from google/cadvisor about 3 years ago by google/cadvisor#2445, as it was no longer used.

This functionality is still used here and makes upgrades difficult.

@dims As one of the people on the cAdvisor Core Team, how do you see this approach.
Any suggestions would be appreciated!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 8, 2023
@hakman
Copy link
Member Author

hakman commented Sep 8, 2023

/hold for comments
/cc @dims

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 8, 2023
@k8s-ci-robot k8s-ci-robot requested a review from dims September 8, 2023 04:14
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2023
@MartinForReal
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2023
@dims
Copy link
Member

dims commented Sep 8, 2023

@hakman hakman force-pushed the demove-dep-cadvisor branch from 728e304 to 5308411 Compare September 8, 2023 12:24
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2023
@hakman hakman force-pushed the demove-dep-cadvisor branch from 5308411 to 7fbd1ca Compare September 8, 2023 12:25
@hakman
Copy link
Member Author

hakman commented Sep 8, 2023

Thanks for the feedback @dims. Updated to use third_party dir, like in k/k.
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2023
@hakman hakman force-pushed the demove-dep-cadvisor branch from 7fbd1ca to 2077606 Compare September 8, 2023 12:28
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 8, 2023
@dims
Copy link
Member

dims commented Sep 8, 2023

/approve
/lgtm

/assign @vteratipally

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2023
@vteratipally
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, hakman, MartinForReal, vteratipally

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8b33e32 into kubernetes:master Sep 8, 2023
@hakman hakman deleted the demove-dep-cadvisor branch September 8, 2023 14:50
@hakman
Copy link
Member Author

hakman commented Sep 8, 2023

Thanks @vteratipally & @dims!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants