-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove direct dependency on google/[email protected] #805
Conversation
/hold for comments |
/lgtm |
@hakman |
728e304
to
5308411
Compare
5308411
to
7fbd1ca
Compare
Thanks for the feedback @dims. Updated to use |
7fbd1ca
to
2077606
Compare
/approve /assign @vteratipally |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, hakman, MartinForReal, vteratipally The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @vteratipally & @dims! |
The
tail
functionality was removed from google/cadvisor about 3 years ago by google/cadvisor#2445, as it was no longer used.This functionality is still used here and makes upgrades difficult.
@dims As one of the people on the cAdvisor Core Team, how do you see this approach.
Any suggestions would be appreciated!