Remove heapster from project dependencies #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
/assign @Random-Liu |
mmiranda96
reviewed
May 17, 2023
| @@ -68,7 +67,7 @@ func NewClientOrDie(npdo *options.NodeProblemDetectorOptions) Client { | |||
| // we have checked it is a valid URI after command line argument is parsed.:) | |||
| uri, _ := url.Parse(npdo.ApiServerOverride) | |||
|
|
|||
| cfg, err := kubernetes.GetKubeClientConfig(uri) | |||
| cfg, err := GetKubeClientConfig(uri) | |||
There was a problem hiding this comment.
Since this is now a function from the package, could we make it package private?
There was a problem hiding this comment.
updated. Thanks!
|
/lgtm Thanks for your contribution! |
k8s-ci-robot
added
the
lgtm
|
/assign @Random-Liu |
|
/assign dchen1107 |
|
/assign @vteratipally |
vteratipally
approved these changes
May 30, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MartinForReal, mmiranda96, vteratipally The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove heapster from project dependencies because it has been retired.
it will make it easier to bump k8s.io dependencies.
We've found that the client-go library doesn't share transport among different clients. And we may need to bump the dependencies to resolve this issue.