-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ExcludeInterfaceRegexp to Net Dev monitor #675
Add ExcludeInterfaceRegexp to Net Dev monitor #675
Conversation
d487884
to
dcb3b42
Compare
3ee4018
to
0577a7d
Compare
/cc @bobbypage |
Change LGTM, a few small nits about the test. Thanks for adding the the exclude feature and test coverage, it's a big improvement! |
0577a7d
to
1471f74
Compare
Addressed your comments @bobbypage. Thanks for the review! |
Thanks! /lgtm /assign @Random-Liu |
@vteratipally Could you take a look at this change? Thanks! |
@mmiranda96 Did you happen to check if adding the filter improving the time reporting the metrics |
@vteratipally I didn't check that specifically, I just ensured that metrics are properly filtered. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bobbypage, mmiranda96, vteratipally The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
As a solution for #659, this PR adds field
ExcludeInterfaceRegexp
to network device monitor. This field is used to stop tracking metrics for certain network interfaces.This change also edits config
net-cgroup-system-stats-monitor.json
to exclude Calico interfaces (according to this doc,cali
andtunl
interfaces) andveth
, which are interfaces created dynamically and only add noise to the metrics.Additionally, I refactored the code in order to make it more testable and added some unit tests.
How to test this change?