-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for basic system metrics for Windows. #554
Conversation
/cc @mcshooter |
@jeremyje: GitHub didn't allow me to request PR reviews from the following users: mcshooter. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update https://github.com/kubernetes/node-problem-detector/tree/master/pkg/systemstatsmonitor about the windows support?
Added some details about Windows support for system metrics to the |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jeremyje, Random-Liu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/sig windows |
This change introduces a system stats monitor support for Windows, #461. Given that node-problem-detector uses gopsutil there's a bunch of metrics that can be forwarded without any code changes. Other parts of NPD require access to /proc and friends which there's no Windows equivalent. Those will need to be accessed through WMI at a later time but for now some were backfilled using gopsutil for Windows.
This change introduces a
config/windows-system-stats-monitor.json
configuration that can be used to expose the system metrics without errors or warnings. It is a subset of functionality that's exposed in Linux.Lastly, this change adds Windows support for
GetOSVersion()
as that's required for running the system metrics handler. Each change also includes a smoke test.With this change the
/metrics
endpoint looks like this.