Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collect CPU load averages in a separate metric #484

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Collect CPU load averages in a separate metric #484

merged 1 commit into from
Nov 12, 2020

Conversation

karan
Copy link
Contributor

@karan karan commented Nov 3, 2020

Tested in a COS VM:

$ curl -s localhost:20257/metrics  | grep -i cpu_load_avg
# HELP cpu_load_avg CPU average load
# TYPE cpu_load_avg gauge
cpu_load_avg{period="15m"} 0.12
cpu_load_avg{period="1m"} 0.23
cpu_load_avg{period="5m"} 0.18

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 3, 2020
@karan
Copy link
Contributor Author

karan commented Nov 3, 2020

/assign @Random-Liu
/cc @vteratipally

@k8s-ci-robot
Copy link
Contributor

@karan: GitHub didn't allow me to request PR reviews from the following users: vteratipally.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/assign @Random-Liu
/cc @vteratipally

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@karan
Copy link
Contributor Author

karan commented Nov 3, 2020

/test pull-npd-e2e-node

@karan
Copy link
Contributor Author

karan commented Nov 3, 2020 •
edited
Loading

Looks like the test is flaky: https://k8s-testgrid.appspot.com/sig-node-node-problem-detector#ci-npd-e2e-node (kubernetes/kubernetes#95357)

Fix tracked in kubernetes/kubernetes#96050

@karan
Copy link
Contributor Author

karan commented Nov 4, 2020

/assign @wangzhen127

@karan
Copy link
Contributor Author

karan commented Nov 4, 2020

/test pull-npd-e2e-node

1 similar comment
@karan
Copy link
Contributor Author

karan commented Nov 5, 2020

/test pull-npd-e2e-node

@karan
Copy link
Contributor Author

karan commented Nov 6, 2020

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 9, 2020
@karan
Copy link
Contributor Author

karan commented Nov 9, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2020
@wangzhen127
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karan, wangzhen127

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2020
@karan
Copy link
Contributor Author

karan commented Nov 12, 2020

/test pull-npd-e2e-node

@k8s-ci-robot k8s-ci-robot merged commit 35bfe69 into kubernetes:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@wangzhen127 wangzhen127 Awaiting requested review from wangzhen127

Assignees

@wangzhen127 wangzhen127

@Random-Liu Random-Liu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karan @k8s-ci-robot @wangzhen127 @Random-Liu