Adapt OOMKilling pattern to old and new Linux kernels #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Friendly ping for a review request @andyxning @xueweiz :). When could one expect a new release of NPD (incorporating this fix)? |
|
/assign @Random-Liu |
|
/lgtm Thanks for the fix! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Random-Liu, tosi3k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
4 similar comments
|
/retest |
|
/retest |
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #480.
Tl;dr: kernel commit torvalds/linux@bbbe480 removed logging the
Kill process %d (%s) score %u or sacrifice child\nOOM message part we look for when tracing the kernel log in the kernel monitor. Because of that, the change removes that part from thekernel-monitor(-filelog).jsonregex pattern to handle both old and new kernel versions.Successfully tested the change using https://github.com/kubernetes/node-problem-detector#try-it-out instruction (appropriate K8s events are emitted for both old and new OOM message formats).
Fixes #480.