-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenCensus and gopsutil as dependency #289
Conversation
Hi @xueweiz. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is also part of #284 |
/assign @wangzhen127 |
/ok-to-test |
If go modules are added after #286, then these packages should be transformed to go modules. Anyway, let's ensure that they are added by go modules. @xueweiz Thanks for the job. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyxning, xueweiz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks so much for the prompt review @andyxning !
|
You reminds me. :) |
These two libraries are needed for #275 to compile.
The changes were made & merged first at #286 . But since then, NPD has switched from Godep to Go Modules (#287 ). This change is re-adding these libraries using Go Modules.
Test: rebase #275 on top of this, and then #275 compiles correctly.