Fix CI job race condition #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @Random-Liu |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
size/XS
wangzhen127
force-pushed
the
ci-race
branch
2 times, most recently
from
5164c1e to
981330d
Compare
|
In this way, you will always have consistent tar + sha |
Random-Liu
reviewed
Mar 19, 2019
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Random-Liu, wangzhen127 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current CI job has race condition. The related CI jobs are:
ci.envfile to staging.ci.envand export the env; then start to run E2E test; when creating the cluster, use the env exported inci.envto download the NPD builds.The CI jobs are configured to run every 2 hours. The race condition happens as follows:
t: All 3 CI jobs run.ci-npd-buildpush the new builds to staging (with new sha1 value).t+2hour: All 3 CI jobs run again.ci-npd-buildstarts to run, but hasn't finished the build.ci-npd-e2e-kubernetes-gce-gcidownloads theci.envpushed in step 1 at timet.t+2hour+2min:ci-npd-buildfinishes building and pushes a new build to staging.t+2hour+5min:ci-npd-e2e-kubernetes-gce-gcicreated the cluster and try to download NPD build. It used the oldci.envas downloaded in step 2, but the NPD build on staging has been updated to the new build in step 3. Then the sha1 value does not match. NPD installation fails with following error:This PR adds current time to version and tag, so that the NPD builds will not be overridden. The GCS bucket is configured to only keep the builds for 7 days, so old files will be cleaned up.
Part of #236.