Add private network implementation for podman

[afbjorklund]

Most of it the same as docker, except for the options.

i.e. libnetwork "bridge" plugin vs. cni "bridge" plugin

Does not remove the network when deleting

Closes #9714

[medyagh]

could podman network benefit from specifying the MTU ? (this fixed the issue of minikube in cloud shell not being able to pull large images like golang:1.15 due to different cloud shell MTUs

[afbjorklund]

It might, but it will not benefit from "com.docker.network.driver.mtu" at any rate.

[afbjorklund]

It will be available in the future (like podman 3.0 or so), with a similar option

[medyagh]

maybe add a comment, to remember TODO add mtu for podman 3 (with an issue liunk)

[medyagh]

does this need to be renamed to networkInspect ? if it is working for both podman and docker ?

[afbjorklund]

There is "docker" all over the place, I didn't rename any functions.

[medyagh]

I mean if we are using it for both docker and podman now (unlike before) we should rename it to networkInspect

[afbjorklund]

Currently it is not possible to configure MTU:

// HostLocalBridge describes a configuration for a bridge plugin
// https://github.com/containernetworking/plugins/tree/master/plugins/main/bridge#network-configuration-reference
type HostLocalBridge struct {
        PluginType   string            `json:"type"`
        BrName       string            `json:"bridge,omitempty"`
        IsGW         bool              `json:"isGateway"`
        IsDefaultGW  bool              `json:"isDefaultGateway,omitempty"`
        ForceAddress bool              `json:"forceAddress,omitempty"`
        IPMasq       bool              `json:"ipMasq,omitempty"`
        MTU          int               `json:"mtu,omitempty"`
        HairpinMode  bool              `json:"hairpinMode,omitempty"`
        PromiscMode  bool              `json:"promiscMode,omitempty"`
        Vlan         int               `json:"vlan,omitempty"`
        IPAM         IPAMHostLocalConf `json:"ipam"`
}

// NewHostLocalBridge creates a new LocalBridge for host-local
func NewHostLocalBridge(name string, isGateWay, isDefaultGW, ipMasq bool, ipamConf IPAMHostLocalConf) *HostLocalBridge {
        hostLocalBridge := HostLocalBridge{
                PluginType:  "bridge",
                BrName:      name,
                IPMasq:      ipMasq,
                HairpinMode: true,
                IPAM:        ipamConf,
        }
        if isGateWay {
                hostLocalBridge.IsGW = true
        }
        if isDefaultGW {
                hostLocalBridge.IsDefaultGW = true
        }
        return &hostLocalBridge
}

So the feature needs to be added to podman first.

[afbjorklund]

Another request for MTU: containers/podman#8454

See #9716 (comment)

[medyagh]

/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afbjorklund, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [afbjorklund,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[minikube-pr-bot]

kvm2 Driver
error collecting results for kvm2 driver: timing run 0 with Minikube (PR 9716): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9716/minikube start --driver=kvm2]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9716/minikube: exec format error
docker Driver
error collecting results for docker driver: timing run 0 with Minikube (PR 9716): timing cmd: [/home/performance-monitor/.minikube/minikube-binaries/9716/minikube start --driver=docker]: starting cmd: fork/exec /home/performance-monitor/.minikube/minikube-binaries/9716/minikube: exec format error

[afbjorklund]

Support for MTU will be available in Podman 3.0, can revisit it again then...

containers/podman#8457