-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hack/update: kubernetes version #9529
hack/update: kubernetes version #9529
Conversation
Hi @prezha. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
Travis tests have failedHey @prezha, 1st Buildmake test
TravisBuddy Request Identifier: 9ddb8210-14ca-11eb-aff7-dd8cbeb067cc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but references hack/update
directory which doesn't yet exist. We'll need to defer merging until that directory is filled in.
Please resolve this comment once that code is merged.
Dependency updated - can you resolve the conflicts? |
fa94a0c
to
2bf6ef6
Compare
@tstromberg similar as with pr #9532: the conflicts were due to the pr #9464 (the original one - before i've split it into several prs) got merged first, and i had a couple of changes made in those individual prs; essentially my fault, i should have had closed the original pr right after the split (but left it just in case anyone wanted to compare)... i've fixed this one now but had to also add here the |
2bf6ef6
to
0a0a021
Compare
Travis tests have failedHey @prezha, 1st Buildmake test
TravisBuddy Request Identifier: 7721da70-2136-11eb-a20b-45518f503c27 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: prezha, tstromberg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fixes: #9464
fixes: #4392
replaces: #9384
pr #9464 ("automate update processes") split: part 2/4:
hack/update/kubernetes_version/update_kubernetes_version.go
hack/kubernetes_version/update_kubernetes_version.go