-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update-context: Automatically set the context as current/active in ku… #9281
update-context: Automatically set the context as current/active in ku… #9281
Conversation
Hi @prezha. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: prezha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #9281 +/- ##
==========================================
- Coverage 29.48% 29.47% -0.02%
==========================================
Files 170 170
Lines 10307 10311 +4
==========================================
Hits 3039 3039
- Misses 6846 6850 +4
Partials 422 422
|
/assign @medyagh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prezha thank you for this PR, would you please put the before/after this PR output in the PR descripion.
@medyagh thank you for your comment - i've added example output before and after this PR (with the common starting point), similar to your example in the issue description please let me know if i should add more details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @prezha for this PR
fixes #9246
example scenario:
common starting point:
before PR:
after PR: