Automated GCP Credentials Addon Prototype #8682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sharifelgamal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Travis tests have failedHey @sharifelgamal, 1st Buildmake testTravisBuddy Request Identifier: 518f2150-c15f-11ea-9c30-6301f8ea01dd |
Travis tests have failedHey @sharifelgamal, 1st Buildmake testTravisBuddy Request Identifier: ce082ee0-c162-11ea-9c30-6301f8ea01dd |
medyagh
reviewed
Jul 8, 2020
tstromberg
suggested changes
Jul 8, 2020
Travis tests have failedHey @sharifelgamal, 1st Buildmake test2nd Buildmake testTravisBuddy Request Identifier: b4baafe0-c166-11ea-9c30-6301f8ea01dd |
Codecov Report
@@ Coverage Diff @@
## master #8682 +/- ##
=======================================
Coverage 32.06% 32.06%
=======================================
Files 161 161
Lines 10532 10532
=======================================
Hits 3377 3377
Misses 6751 6751
Partials 404 404 |
medyagh
requested changes
Jul 15, 2020
|
/ok-to-test |
k8s-ci-robot
added
the
ok-to-test
|
kvm2 Driver |
k8s-ci-robot
added
size/XL
|
kvm2 Driver Times for Minikube (PR 8682): [64.74906590900001 66.053445413 64.015299081] Averages Time Per Log docker Driver Times for Minikube (PR 8682): [26.20623305 26.123966673 24.975827609] Averages Time Per Log |
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
|
kvm2 Driver Times for Minikube (PR 8682): [62.33771455499999 64.51695032999999 65.03033938] Averages Time Per Log docker Driver Times for Minikube (PR 8682): [25.438511258 25.997516801 24.783536225000006] Averages Time Per Log |
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
|
kvm2 Driver Times for Minikube (PR 8682): [56.217019945999986 61.431176793000006 57.459713404999995] Averages Time Per Log docker Driver Times for Minikube (PR 8682): [26.039622831000003 26.567360379999997 25.719606344] Averages Time Per Log |
medyagh
approved these changes
Jul 21, 2020
|
kvm2 Driver Times for Minikube (PR 8682): [61.82875216200001 63.190716321 61.994711349] Averages Time Per Log docker Driver Times for Minikube (PR 8682): [25.573163084999997 25.660444872000003 27.310304325999997] Averages Time Per Log |
|
kvm2 Driver Times for Minikube (PR 8682): [58.474514056000004 63.066704156 66.11227497899999] Averages Time Per Log docker Driver Times for Minikube (PR 8682): [25.537851022 26.696834380999995 27.461784608000002] Averages Time Per Log |
|
This change is 💯 💯 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can enable the addon with
minikube addons enable gcp-auth. Credentials are retrieved from wherever GCP would normally find them, which varies platform to platform. The credentials file location can always be overridden by specifying the GOOGLE_APPLICATION_CREDENTIALS environment variable.If a user doesn't want a specific pod to have creds injected, they can add the "gcp-auth-skip-secret" label to their pod yaml.
Fixes #8379