Convert PVC storage path to /var/tmp #7865

jradtilbrook · 2020-04-23T15:31:25Z

This changes the mount volume of the storage provisioner to /var/tmp on the host system.
On modern linux systems this is a normal mount point, as compared to /tmp which is generally a tmpfs which is removed upon reboots so persistant volume claims are not actually persistent.

k8s-ci-robot · 2020-04-23T15:31:29Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2020-04-23T15:31:33Z

Welcome @jradtilbrook!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2020-04-23T15:31:33Z

Hi @jradtilbrook. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2020-04-23T15:31:40Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jradtilbrook
To complete the pull request process, please assign ra489
You can assign the PR to them by writing /assign @ra489 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

codecov-io · 2020-04-23T15:37:15Z

Codecov Report

Merging #7865 into master will decrease coverage by 1.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7865      +/-   ##
==========================================
- Coverage   36.68%   35.57%   -1.12%     
==========================================
  Files         146      148       +2     
  Lines        8978     9297     +319     
==========================================
+ Hits         3294     3307      +13     
- Misses       5292     5593     +301     
- Partials      392      397       +5

Impacted Files	Coverage Δ
pkg/minikube/perf/start.go	`30.00% <0.00%> (-21.36%)`	⬇️
pkg/minikube/cruntime/containerd.go	`28.65% <0.00%> (-15.10%)`	⬇️
pkg/minikube/bootstrapper/images/images.go	`87.50% <0.00%> (-12.50%)`	⬇️
cmd/minikube/cmd/node_start.go	`10.00% <0.00%> (-12.23%)`	⬇️
pkg/minikube/out/out.go	`46.57% <0.00%> (-12.05%)`	⬇️
pkg/minikube/command/ssh_runner.go	`0.00% <0.00%> (-10.35%)`	⬇️
pkg/minikube/kubeconfig/kubeconfig.go	`61.06% <0.00%> (-7.63%)`	⬇️
cmd/minikube/cmd/node_stop.go	`14.28% <0.00%> (-5.72%)`	⬇️
pkg/minikube/proxy/proxy.go	`96.96% <0.00%> (-3.04%)`	⬇️
cmd/minikube/cmd/delete.go	`22.13% <0.00%> (-2.98%)`	⬇️
... and 43 more

minikube-bot · 2020-04-23T15:39:03Z

Can one of the admins verify this patch?

jradtilbrook · 2020-04-23T15:41:00Z

/check-cla

jradtilbrook · 2020-04-23T15:45:30Z

The CLA has been signed

tstromberg · 2020-04-23T16:15:18Z

/ok-to-test

minikube-pr-bot · 2020-04-23T16:29:10Z

kvm2 Driver
docker Driver

RA489 · 2020-04-28T09:09:27Z

/check-cla

tstromberg · 2020-04-29T16:05:28Z

/ok-to-test

tstromberg · 2020-04-29T16:05:43Z

need any help with the CLA?

jradtilbrook · 2020-04-30T12:37:40Z

need any help with the CLA?

Sorry @tstromberg it wasn't working and I forgot to come back to it. I believe I've done it now

jradtilbrook · 2020-04-30T12:42:24Z

The logs are so verbose I'm not quite sure what the error is. If you can provide any more detail that would be much appreciated! 🙏

tstromberg · 2020-05-01T17:25:06Z

KVM had the folowing failures that did not seem related:

TestErrorSpam - 369.91s
TestFunctional/parallel/ServiceCmd - 83.45s
TestStartStop/group/crio - 780.94s

Likewise docker had:

TestStartStop/group/old-k8s-version - 867.57s
TestStartStop/group/containerd - 356.23s
TestStartStop/group/crio - 930.88s
TestStartStop/group/embed-certs - 794.46s
TestFunctional/parallel/ServiceCmd - 59.56s
TestPause/serial/SecondStartNoReset - 47.51s

Our integration tests are pretty flaky at the moment. They all seem unrelated, but I'll re-run the tests to see if any of these are consistent.

tstromberg · 2020-05-01T17:25:22Z

/ok-to-test

jradtilbrook · 2020-05-06T04:18:33Z

@tstromberg Is there anything I can do to assist?

tstromberg · 2020-05-07T17:10:54Z

I'm going to have to give this some thought on how to roll this out:

If a user upgrades their minikube, but have an older cluster running - they will end up with a new storage provisioner running on an old ISO. How should we we handle that?

priyawadhwa

cc @tstromberg

We could add a template field to path in storage-provisioner.yaml.tmpl

path: {{.TmpHostPath}}

and we could set TmpHostPath=/tmp if minikube version < 1.11 and TmpHostPath=/var/tmp if minikube version >= 1.11.

WDYT?

afbjorklund · 2020-07-21T07:41:06Z

This also needs to be synchronized with the kicbase implementation:

302a6b0 "Add minimal minikube-automount to the kic image"

As well as documented properly, for current users of the "none" drivers.

https://minikube.sigs.k8s.io/docs/handbook/persistent_volumes/

As I wrote in the issue #7511 (comment), I don't think this change is worth it...

The /tmp location was never meant for storage... And /var/tmp might not be ideal.

fejta-bot · 2020-10-19T08:17:41Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

k8s-ci-robot · 2020-10-19T08:17:45Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jradtilbrook · 2020-11-18T12:40:57Z

@sharifelgamal I noticed you removed the stale label. I'm wondering if I should just close this as stale. I don't have time to work on it and have fixed my own issue with a bind mount on my host manually for now

medyagh · 2020-11-25T19:28:54Z

@sharifelgamal I noticed you removed the stale label. I'm wondering if I should just close this as stale. I don't have time to work on it and have fixed my own issue with a bind mount on my host manually for now

@jradtilbrook
do u mind sharing the steps u did manually to fix ?

jradtilbrook · 2020-11-26T04:50:53Z

@jradtilbrook
do u mind sharing the steps u did manually to fix ?

@medyagh I enabled a systemd mount unit that bind mounts the directory onto /var/tmp. You can see the unit file at https://github.com/jradtilbrook/dotfiles/blob/master/files/etc/systemd/system/tmp-hostpath%5Cx2dprovisioner.mount

tstromberg · 2020-12-09T19:15:52Z

Closing by request until author has a chance to revisit this.

jradtilbrook added 2 commits April 23, 2020 23:25

Mount /var/tmp to storage-provisioner pod

f487b73

Change iso paths to /var/tmp

d8b7876

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 23, 2020

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 23, 2020

k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 23, 2020

k8s-ci-robot requested review from medyagh and RA489 April 23, 2020 15:31

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 23, 2020

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 30, 2020

priyawadhwa added the triage/discuss Items for discussion label May 19, 2020

priyawadhwa reviewed May 20, 2020

View reviewed changes

priyawadhwa removed the triage/discuss Items for discussion label May 20, 2020

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 19, 2020

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 19, 2020

sharifelgamal removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 11, 2020

tstromberg closed this Dec 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert PVC storage path to /var/tmp #7865

Convert PVC storage path to /var/tmp #7865

jradtilbrook commented Apr 23, 2020 •

edited

Loading

k8s-ci-robot commented Apr 23, 2020

k8s-ci-robot commented Apr 23, 2020

k8s-ci-robot commented Apr 23, 2020

k8s-ci-robot commented Apr 23, 2020

codecov-io commented Apr 23, 2020

minikube-bot commented Apr 23, 2020

jradtilbrook commented Apr 23, 2020

jradtilbrook commented Apr 23, 2020

tstromberg commented Apr 23, 2020

minikube-pr-bot commented Apr 23, 2020

RA489 commented Apr 28, 2020

tstromberg commented Apr 29, 2020

tstromberg commented Apr 29, 2020

jradtilbrook commented Apr 30, 2020

jradtilbrook commented Apr 30, 2020

tstromberg commented May 1, 2020

tstromberg commented May 1, 2020

jradtilbrook commented May 6, 2020

tstromberg commented May 7, 2020

priyawadhwa left a comment •

edited

Loading

afbjorklund commented Jul 21, 2020 •

edited

Loading

fejta-bot commented Oct 19, 2020

k8s-ci-robot commented Oct 19, 2020

jradtilbrook commented Nov 18, 2020

medyagh commented Nov 25, 2020

jradtilbrook commented Nov 26, 2020

tstromberg commented Dec 9, 2020

Convert PVC storage path to /var/tmp #7865

Convert PVC storage path to /var/tmp #7865

Conversation

jradtilbrook commented Apr 23, 2020 • edited Loading

k8s-ci-robot commented Apr 23, 2020

k8s-ci-robot commented Apr 23, 2020

k8s-ci-robot commented Apr 23, 2020

k8s-ci-robot commented Apr 23, 2020

codecov-io commented Apr 23, 2020

Codecov Report

minikube-bot commented Apr 23, 2020

jradtilbrook commented Apr 23, 2020

jradtilbrook commented Apr 23, 2020

tstromberg commented Apr 23, 2020

minikube-pr-bot commented Apr 23, 2020

RA489 commented Apr 28, 2020

tstromberg commented Apr 29, 2020

tstromberg commented Apr 29, 2020

jradtilbrook commented Apr 30, 2020

jradtilbrook commented Apr 30, 2020

tstromberg commented May 1, 2020

tstromberg commented May 1, 2020

jradtilbrook commented May 6, 2020

tstromberg commented May 7, 2020

priyawadhwa left a comment • edited Loading

Choose a reason for hiding this comment

afbjorklund commented Jul 21, 2020 • edited Loading

fejta-bot commented Oct 19, 2020

k8s-ci-robot commented Oct 19, 2020

jradtilbrook commented Nov 18, 2020

medyagh commented Nov 25, 2020

jradtilbrook commented Nov 26, 2020

tstromberg commented Dec 9, 2020

jradtilbrook commented Apr 23, 2020 •

edited

Loading

priyawadhwa left a comment •

edited

Loading

afbjorklund commented Jul 21, 2020 •

edited

Loading