-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimizing Chinese translation #5201
Conversation
Welcome @BlackHole1! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @BlackHole1. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can one of the admins verify this patch? |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BlackHole1 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/check-cla |
@BlackHole1 - Please visit https://identity.linuxfoundation.org/projects/cncf to sign the CLA. Thank you! |
/check-cla |
This looks good. Can it be merged yet? |
I am also thinking about this problem because I found in the process of translation that if all the keywords are translated, some programmers in mainland China may not be able to go to google well. Because most of the problems on google are in English, if you search in Chinese, you may get nothing. I'd like to hear your opinion. @tstromberg |
Getting the problems translated would be nice, but not necessary for the first PR: there is a lot of text there. |
@tstromberg Ok, but please wait a few days, I'm adding some. |
Hey @BlackHole1, thanks for opening this PR. We recently updated some of these translations, so you'll have to rebase your PR and fix any merge conflicts. Other than that, is this ready to be merged? |
96a4b1c
to
910a69e
Compare
@priyawadhwa @tstromberg hi guys. This branch has rebased the latest master branch code. And perfect a little translation. Now it can be merged. |
Codecov Report
@@ Coverage Diff @@
## master #5201 +/- ##
=======================================
Coverage 36.86% 36.86%
=======================================
Files 102 102
Lines 7349 7349
=======================================
Hits 2709 2709
Misses 4289 4289
Partials 351 351 |
/ok-to-test |
Thank you! |
No description provided.