Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nginx ingress to 0.25.0 #4785

Merged
merged 1 commit into from
Jul 28, 2019
Merged

Upgrade nginx ingress to 0.25.0 #4785

merged 1 commit into from
Jul 28, 2019

Conversation

reegnz
Copy link
Contributor

@reegnz reegnz commented Jul 17, 2019

No description provided.

@k8s-ci-robot
Copy link
Contributor

Welcome @reegnz!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 17, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @reegnz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: reegnz
To complete the pull request process, please assign medyagh
You can assign the PR to them by writing /assign @medyagh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link
Contributor

@tstromberg tstromberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@medyagh
Copy link
Member

medyagh commented Jul 17, 2019

/retest this please

@medyagh
Copy link
Member

medyagh commented Jul 17, 2019

Thanks fort this contribution, @reegnz
I am curious, was there any issue with the current version that motivated you to update the version ? (not that I don't like newer verison but I am just curious if users were facing an issue that I should be aware of ? )

@tstromberg
Copy link
Contributor

Marking as WIP, as it appears that the integration test may need to be adjusted:

 --- FAIL: TestFunctional/IngressController (102.33s)
        addons_test.go:165: ExpectedStr sshCmdOutput to be: Welcome to nginx!. Output was: curl: (56) Recv failure: Connection reset by peer

See https://github.com/kubernetes/minikube/blob/master/docs/contributors/build_guide.md#integration-tests for some guidance.

@tstromberg tstromberg added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 17, 2019
@RA489
Copy link

RA489 commented Jul 18, 2019

@minikube-bot OK to test

@reegnz
Copy link
Contributor Author

reegnz commented Jul 18, 2019

@medyagh there had been a few new features in the ingress-controller that I am want to use in minikube:

Especially the secure-by-default thingy is something we want to use in production, and it would be great to be able to use in our devenv as well with the minikube default ingress plugin.

@reegnz
Copy link
Contributor Author

reegnz commented Jul 18, 2019

@tstromberg I'll get onto fixing the integration tests then.

@RA489
Copy link

RA489 commented Jul 22, 2019

@reegnz please fix the integration test rest LGTM.

@reegnz
Copy link
Contributor Author

reegnz commented Jul 22, 2019

@tstromberg that is a weird failure for the integration test, it's a generic curl failure message.
I will try and debug, since I have a feeling this is an issue on the ingress-contoller side.

What's hard in this case is that the ingress controller logs aren't available for debugging, so I have to reproduce that myself -> maybe improve on the test logging in case of errors.

@reegnz
Copy link
Contributor Author

reegnz commented Jul 22, 2019

It seems like something regarding ClusterRoles has changed:

E0722 08:41:12.989145       6 reflector.go:125] pkg/mod/k8s.io/[email protected]/tools/cache/reflector.go:98: Failed to list *v1beta1.Ingress: ingresses.networking.k8s.io is forbidden: User "system:serviceaccount:kube-system:nginx-ingress" cannot list resource "ingresses" in API group "networking.k8s.io" at the cluster scope.

Checking the difference between upstream ingress-controller manifests and the ones in minikube.

(suggestion: instead of maintaining it's own set of manifests, minikube should kustomize the upstream resources instead).

@reegnz
Copy link
Contributor Author

reegnz commented Jul 22, 2019

@medyagh please check again, everything should be in order now.

@medyagh
Copy link
Member

medyagh commented Jul 28, 2019

looks good to me ! thank you for this contribution !

@medyagh medyagh merged commit 396a65a into kubernetes:master Jul 28, 2019
@reegnz reegnz deleted the upgrade-nginx branch August 6, 2019 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants