Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Hyper-V daemons #4030

Merged
merged 6 commits into from
Apr 10, 2019
Merged

Update Hyper-V daemons #4030

merged 6 commits into from
Apr 10, 2019

Conversation

laozc
Copy link
Contributor

@laozc laozc commented Apr 1, 2019

Currently only KVP daemons are complied and installed into the minikube ISO.
There are a few more Hyper-V daemons for integration services needed like Fcopy and VSS.
This PR includes new configuration to enable these daemons in minikube.

  • Guest service is not enabled by default. Once it's checked in Hyper-V setting, the Fcopy daemon will be brought up by systemd, in which case you may leverage FCopy cmdlet to copy file into the VM

laozc added 6 commits March 30, 2019 19:20
@laozc
Install required scripts for Hyper-V KVP daemon
f18136d 
Signed-off-by: Zhongcheng Lao <[email protected]>
@laozc
Install Hyper-V VSS daemon
47f4d2e 
Signed-off-by: Zhongcheng Lao <[email protected]>
@laozc
Install Hyper-V FCOPY daemon
def1a55 
Signed-off-by: Zhongcheng Lao <[email protected]>
@laozc
Add udev rules to generate devices for Hyper-V daemons
e0d7363 
Signed-off-by: Zhongcheng Lao <[email protected]>
@laozc
Merge Hyper-V deamon packages to hyperv-daemons
e8cdc4b 
Signed-off-by: Zhongcheng Lao <[email protected]>
@laozc
Do not attempt to restart service on failures for Hyper-V daemons
9a5f3c2 
Service restart may not work when a specific integration service
is disabled in the VM setting. Remove the setting for performance
concerns.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: laozc
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dlorenc

If they are not already assigned, you can assign the PR to them by writing /assign @dlorenc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 1, 2019
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@tstromberg
Copy link
Contributor

@minikube-bot OK to test

@tstromberg
Copy link
Contributor

Thank you!

@tstromberg tstromberg merged commit 14414d1 into kubernetes:master Apr 10, 2019
@laozc laozc deleted the fix-hv-daemon branch April 11, 2019 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laozc @k8s-ci-robot @minikube-bot @tstromberg